toml_config: add [job].upload_reproducible_setup, default False for OSS#92
Merged
Conversation
The VLM base config defaults upload_reproducible_setup=True, so a run
launched through the structured-TOML flow attempts the reproducible-setup
S3 upload (and wandb save_s3, which interpolate from
${upload_reproducible_setup}) by default. OSS users mostly have no S3
access and no way to turn it off from the TOML.
Add a [job].upload_reproducible_setup knob (default False) that maps to the
top-level config.upload_reproducible_setup:
- JobConfig gains the field (default False).
- PATH_REMAPS (vfm + vlm) hoist ("job","upload_reproducible_setup") to the
top-level ("upload_reproducible_setup",).
- load_experiment_from_toml keeps the validated model and always injects the
resolved value into raw before building overrides, so the override is
emitted as false even when the TOML omits it (build_hydra_overrides walks
the raw dict, so an omitted field would otherwise emit nothing and the base
True would win).
Users opt back into S3 upload with `upload_reproducible_setup = true`.
Docs (sft_config.md) + all example [job] blocks updated; adds
tests/toml_config_test.py.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
yy-code-nv
force-pushed
the
oss-toml-upload-reproducible-setup
branch
from
2920306 to
ee4f63e
Compare
lfengad
approved these changes
Jul 8, 2026
yy-code-nv
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VLM base config defaults upload_reproducible_setup=True, so a run launched through the structured-TOML flow attempts the reproducible-setup S3 upload (and wandb save_s3, which interpolate from ${upload_reproducible_setup}) by default. OSS users mostly have no S3 access and no way to turn it off from the TOML.
Add a [job].upload_reproducible_setup knob (default False) that maps to the top-level config.upload_reproducible_setup:
Users opt back into S3 upload with
upload_reproducible_setup = true.Docs (sft_config.md) + all example [job] blocks updated; adds tests/toml_config_test.py.