[SkipRecovery] Restore randomized regex choice coverage [reduced-it] [databricks] - #15965
Open
wjxiz1992 wants to merge 1 commit into
Open
[SkipRecovery] Restore randomized regex choice coverage [reduced-it] [databricks]#15965wjxiz1992 wants to merge 1 commit into
wjxiz1992 wants to merge 1 commit into
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Test-only changes are validated, with no unresolved review comments.
Pull request overview
Restores randomized regex-choice regression coverage for CRLF-anchored alternatives without production changes.
Changes:
- Removes the temporary fixed seed override.
- Adds the historical
aab2ab\r\ninput as a generator special case.
File summaries
| File | Description |
|---|---|
integration_tests/src/main/python/regexp_test.py |
Updates regex test data generation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Collaborator
Author
|
build |
thirtiseven
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JaCoCo production line coverage: +0 lines (measured:
delta-lake,iceberg,shuffle-plugin,sql-plugin,udf-compiler; Scala 2.12, shim 350, anchor2d438c02, vs nightly coverage b34)Fixes #10641.
Description
This test-only recovery restores randomized coverage for regex alternatives containing end-of-line anchors.
test_regexp_choicestill pins seed 0 after a historical CRLF capture mismatch, although the underlying fixes have merged. Production behavior is unchanged; the original failing input and seed now pass CPU/GPU comparison on current main.Remove the temporary seed override and add the original
aab2ab\r\ninput to the existing generator's special cases. All 12 SQL expressions and their parity assertions remain unchanged. Other regex limitations and fallback tests are outside this change.The underlying fixes are cuDF #22763 (CRLF anchor semantics) and #15023 (removal of the consuming CRLF rewrite).
AI assistance: The change and PR description were prepared with Codex assistance.
Validation
Apache Spark 3.5.0 / Scala 2.12 / Python 3.10.18 / Java 17 / UTC:
ab2ab, without the trailing CR;GpuRegExpExtractpresence was asserted.regexp_test.py, seed1711561563, xfail masking disabled: 95 passed, 1 skipped. The unchanged skip requires Spark 4.0+.0,20260911, and42: 1 passed each. Original seed with OOM injection forced: 1 passed.[reduced-it]retains the affected test's only collected case: it has no parametrization decorators, and pre-commit reduced collection was checked. Scala UT scheduling remains parallel. Databricks validation is requested through the title marker; no local Databricks pass is claimed.Reproduction commands and artifact evidence
Build source:
e56c2660c762033f63e39df59c9276d5eb6e81e9.Built plugin SHA-256:
4b460b3390641dc617ccc2769f160e4824fbdde182c12d8ddb42715ce47d6d84. Its JNI dependency embeds cuDF revisionf76d700abdd316b406ca825a269b73153632742d, which contains the merged CRLF fix.Coverage: replayed the modified test successfully against the exact nightly class-anchor JAR (
2d438c02049635368d2db1a7189b2093d206bad9, SHA-256e38843bef80d8a33c33a6ba49344f11764cab64a3875747c866176fd5d6402fc) from coverage b34. Each module's regenerated baseline counters equal the published report, and merging the test execution adds no lines. No class-ID mismatch orMemoryCheckerImplartifact was present. This restores randomized regression coverage, not new production-line coverage. The newer b21 report was not used because its Iceberg execution data has class-ID mismatches.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance