Skip Iceberg 1.9.2 REST deletion vector tests [reduced-it] - #15974
Merged
Merged
Conversation
Iceberg 1.9.2 leaks connections on S3 range reads of deletion vectors. Skip only the test parameters that can read deletion vectors so unaffected REST catalog coverage continues to run. Signed-off-by: Chong Gao <chongg@nvidia.com>
Contributor
 |
Signed-off-by: Chong Gao <chongg@nvidia.com>
res-life
changed the title
Collaborator
Author
|
build |
1 similar comment
Collaborator
Author
|
build |
|
|
||
|
|
||
| runtime_iceberg_version = os.environ.get("EXPECTED_ICEBERG_VERSION") | ||
| iceberg_192_rest_deletion_vector_skip_mark = pytest.mark.skipif( |
Collaborator
There was a problem hiding this comment.
I would treat 1.9.2's dv support as incomplete, why not just fix supports_iceberg_v3 to be >1.9.2?
Collaborator
Author
There was a problem hiding this comment.
Confirmed. Iceberg 1.9.2 predates the upstream S3InputStream connection-leak fix, and there is no 1.9.3 release. The first release containing the fix is 1.10.0, so I changed the v3 support gate to require Iceberg 1.10.0 or later.
Signed-off-by: Chong Gao <chongg@nvidia.com>
Collaborator
Author
|
build |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Signed-off-by: Chong Gao <chongg@nvidia.com>
Collaborator
Author
|
build |
liurenjie1024
approved these changes
Sep 14, 2026
Collaborator
Author
|
build |
Collaborator
Author
|
build |
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15970.
Description
This skips only the Iceberg 1.9.2 REST catalog test parameters that may read deletion vectors. It preserves unaffected REST catalog coverage while avoiding connection-pool exhaustion that can poison later S3 requests in the same pytest worker/JVM.
Iceberg 1.9.2 leaks an HTTP connection for each S3 range read of a deletion vector. The shared conditional skip covers the four reader variants of
test_iceberg_v3_deletion_vectorand the merge-on-read parameters of the v3 DELETE, UPDATE, and MERGE fallback tests. Copy-on-write, non-REST, and newer-Iceberg coverage remains enabled.Validation:
format-version=3table creation.mvn -Dbuildver=354 -DskipTests -Drat.skip=true clean install: passed.mvn package -f scala2.13/ -pl integration_tests -am -P individual,pre-merge -Dbuildver=350 -Dmaven.scalastyle.skip=true -Drat.skip=true -DskipTests=true: passed.python -m py_compilefor all changed Python files andgit diff --check: passed.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance