[BUG] Fail closed on incomplete aggregate result mapping - #15979
Draft
zpuller wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Zach Puller <zpuller@nvidia.com>
zpuller
force-pushed
the
test/15808-fail-closed
branch
from
September 11, 2026 21:52
cac3df0 to
c54c013
Compare
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15808.
Description
Positional result mapping for partial typed-imperative aggregates previously used an optional lookup that silently retained the original data type when the expected result expression was missing. This could allow GPU conversion to proceed with inconsistent aggregate buffer metadata.
This change records an incomplete positional mapping during metadata construction and marks the aggregate as unsupported during GPU tagging. It adds a unit regression that removes the expected shuffle-facing result expression from a real partial
ObjectHashAggregateExecand verifies that GPU conversion fails closed.Validation:
sr-test --suite com.nvidia.spark.rapids.HashAggregatesSuite --buildver 357 --no-installgit diff --checkAI assistance disclosure: Codex assisted with implementation, testing, and drafting this description. The author reviewed the complete diff and final description before PR creation.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance
Performance testing is not required because this changes only driver-side plan metadata validation and adds no runtime row or batch processing.