Conversation
Signed-off-by: Chong Gao <chongg@nvidia.com>
Collaborator
Author
|
build |
Contributor
|
Collaborator
Author
|
duplicated with #15985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI regression introduced in #15944.
Description
Add the missing
system_runtime_path()stub to the root-safe packaging test's synthetic Iceberg runtime module.The standard assembler requires this interface after #15957, but the test fixture only provides
coordinates(), causingKeyError: 'system_runtime_path'during Maven verification. ReturningNonemodels the test's unconfigured system runtime and lets both assembler paths reach the existing placement and deduplication assertions. Production code is unchanged.Validation:
env TMPDIR=/home/chongg/codex/tmp/tmp python3 dist/scripts/tests/test_root_safe_provider_selection.py: reproduced theKeyErrorbefore the fix; passed after the fix, including standard and fast assembler subtests.git diff --check: passed.AI assistance: prepared with Codex.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance