Skip to content

TEST: Reuse DataFrame dot test inputs - #24121

Open
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/reuse-dataframe-dot-test-inputs
Open

TEST: Reuse DataFrame dot test inputs#24121
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/reuse-dataframe-dot-test-inputs

Conversation

@vyasr

@vyasr vyasr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description

Reuses the existing left-hand DataFrame inputs while retaining every right-hand operand and pandas comparison in the DataFrame dot test matrix.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner September 10, 2026 21:30
@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue improvement Improvement / enhancement to an existing function labels Sep 10, 2026
@vyasr
vyasr requested a review from rjzamora September 10, 2026 21:30
@vyasr vyasr added the non-breaking Non-breaking change label Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eb8daef6-e3e8-477c-bc0e-dd983989011a

📥 Commits

Reviewing files that changed from the base of the PR and between e78c254 and a102d3d.

📒 Files selected for processing (1)
  • python/cudf/cudf/tests/dataframe/test_binops.py

Included review availability: Your plan provides up to 12 included reviews per hour; 4 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Refactored dot-product test coverage to use shared operand factories.
    • Continued validating consistent results across DataFrames, Series, NumPy arrays, lists, pandas, and cuDF.

Walkthrough

The dot-product test now uses a shared collection of operand factories. It tests DataFrame, Series, NumPy array, and list operands while preserving pandas-versus-cuDF result comparisons.

Changes

Dot-product test coverage

Layer / File(s) Summary
Shared operand factories and test execution
python/cudf/cudf/tests/dataframe/test_binops.py
DOT_OTHER_FACTORIES defines dot-product operand factories. test_binops_dot iterates over the factories internally and retains pandas-versus-cuDF equality checks.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: galipremsagar, bdice

Merge Risk: ⚪ Minimal · up to a102d

The dot-product test refactor retains coverage and result comparisons across the supported operand types, with no actionable merge risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately explains that the PR reuses left-hand DataFrame inputs while preserving right-hand operands and pandas comparisons in the dot-product test matrix.
Title check ✅ Passed The title clearly identifies the main change: reusing inputs in the DataFrame dot-product test.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant