Skip to content

TEST: Reuse ORC reader test inputs - #24124

Open
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/reuse-orc-reader-test-inputs
Open

TEST: Reuse ORC reader test inputs#24124
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/reuse-orc-reader-test-inputs

Conversation

@vyasr

@vyasr vyasr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description

Reuses the expected data derived from each ORC file while retaining every engine and index-handling comparison.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner September 10, 2026 21:30
@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue labels Sep 10, 2026
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8304c8d7-aa9d-43f8-b6a1-b298b8977a7d

📥 Commits

Reviewing files that changed from the base of the PR and between e78c254 and 3eeb4d1.

📒 Files selected for processing (1)
  • python/cudf/cudf/tests/input_output/test_orc.py

Included review availability: Your plan provides up to 12 included reviews per hour; 2 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated ORC reader test coverage to validate multiple engines and index configurations within a single test.
    • Simplified expected-result handling during comparisons.

Walkthrough

The basic ORC reader test now checks both ORC engines with both index settings. It converts the expected dataframe to cuDF once before performing the comparisons.

Changes

ORC reader test coverage

Layer / File(s) Summary
ORC reader configuration matrix
python/cudf/cudf/tests/input_output/test_orc.py
test_orc_reader_basic now loops over both engines and index settings. The expected dataframe is converted to cuDF once before comparison.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mroeschke, bdice

Merge Risk: ⚪ Minimal · up to 3eeb4

The test-only change preserves ORC reader configuration coverage with no actionable merge risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: reusing ORC reader test inputs.
Description check ✅ Passed The description directly explains the test optimization and confirms that engine and index comparisons remain covered.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant