Skip to content

Reuse null comparison helper in single-column sorting #24142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PointKernel wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Reuse null comparison helper in single-column sorting #24142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/src/sort/sort_column_impl.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ struct simple_comparator {
__device__ bool operator()(size_type lhs, size_type rhs)
{
if (has_nulls) {
bool lhs_null{d_column.is_null(lhs)};
bool rhs_null{d_column.is_null(rhs)};
bool const lhs_null{d_column.is_null(lhs)};
bool const rhs_null{d_column.is_null(rhs)};
if (lhs_null || rhs_null) {
if (!ascending) { cuda::std::swap(lhs_null, rhs_null); }
return (null_precedence == cudf::null_order::BEFORE ? !rhs_null : !lhs_null);
return null_compare(lhs_null, rhs_null, null_precedence) ==
(ascending ? weak_ordering::LESS : weak_ordering::GREATER);
}
}

Expand Down
Loading