Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/cuml/cuml/_thirdparty/sklearn/preprocessing/_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -1943,6 +1943,10 @@ def __init__(self, norm='l2', *, copy=True):
self.norm = norm
self.copy = copy

@classmethod
def _get_param_names(cls):
return super()._get_param_names() + ["norm", "copy"]

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.requires_fit = False
Expand Down
30 changes: 30 additions & 0 deletions python/cuml/tests/test_compose.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,36 @@ def test_column_transformer_named_transformers_(clf_dataset): # noqa: F811
assert cu_named_transformers.keys() == sk_named_transformers.keys()


def test_normalizer_sklearn_clone_preserves_parameters():
normalizer = cuNormalizer(norm="l1", copy=False)

cloned = sk_clone(normalizer)

assert cloned.norm == "l1"
assert cloned.copy is False


def test_column_transformer_preserves_normalizer_norm():
X = np.array([[0.0, 1.0, 2.0, 2.0], [1.0, 1.0, 0.0, 1.0]])

cu_transformer = cuColumnTransformer(
[
("norm1", cuNormalizer(norm="l1"), [0, 1]),
("norm2", cuNormalizer(norm="l1"), slice(2, 4)),
]
)
sk_transformer = skColumnTransformer(
[
("norm1", skNormalizer(norm="l1"), [0, 1]),
("norm2", skNormalizer(norm="l1"), slice(2, 4)),
]
)

assert_allclose(
cu_transformer.fit_transform(X), sk_transformer.fit_transform(X)
)


def test_column_transformer_sklearn_clone_preserves_transformers():
transformer = cuColumnTransformer(
[("one_hot_encoder", skOneHotEncoder(), ["a", "b"])]
Expand Down
Loading