Bump oldest CUDA 12 cuda-bindings to 12.9.3 - #8585
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change removes the ChangesCUDA bindings dependency alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The update raises cuda-bindings minimum versions consistently so cuML wheel dependency resolution can select compatible CUDA bindings. No remaining merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Out of Scope Changes checkExplanation The pull request also removes the rapidsai Conda channel and updates CUDA 13 cuda-bindings pins to 13.0.2. These changes are not required by issue
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
All CI failures are unrelated to this change:
All relevant oldest-deps coverage passes, including the cuML and cuML Dask wheel tests. This confirms that updating |
jameslamb
left a comment
There was a problem hiding this comment.
Approving so you have what you need once you've addressed my comments... but I think more is needed here.
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Simon and James! 🙏
Have added suggestions for dependencies.yaml below to capture some of James' recommendations
Would still need to update Conda recipes and other files separately (as James noted)
…-bindings-conflict
Updates the oldest CUDA 12
cuda-bindingspin to12.9.3to match the minimum version required bycudf26.12.Closes #8584