Fix SVR zero-delta kernel cache state - #8605
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change permits working-set reinitialization after completed batching and adds an SVR regression test for degree-10 polynomial kernels. The test verifies that fitting completes and produces a finite one-dimensional prediction. ChangesSVR working-set handling
Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to This restores degree-10 polynomial SVR fitting while preserving protection against incomplete batching, with regression coverage confirming a finite prediction. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
|
@sylvesterkaczmarek please avoid merging upstream main unless it is absolutely necessary to preserve CI resources. Thank you. |
|
Understood. I will avoid merging upstream main into cuML PR branches unless it is necessary for conflict resolution or specifically requested for validation. |
|
@csadorf The Label Checker is currently failing because the PR has no changelog category/breaking classification. I do not have permission to add repository labels. Could a maintainer please add |
Closes #8579
Summary
Validation
python3 -m py_compile python/cuml/tests/test_svm.pygit diff --check