-
Notifications
You must be signed in to change notification settings - Fork 670
Add NVIDIA AI Workbench project scaffolding #8627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myli5
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
myli5:enh-workbench-project-scaffolding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # apt packages to install should be listed one per line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
| # This file contains bash commands that will be executed when the Project container starts. | ||
| # | ||
| # Note: Passwordless sudo is available during the execution of this script | ||
| # Note: This file may be removed if you don't need to use it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
| # This file contains bash commands that will be executed at the end of the container build process, | ||
| # after all system packages and programming language specific package have been installed. | ||
| # | ||
| # Note: This file may be removed if you don't need to use it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
| # This file contains bash commands that will be executed at the beginning of the container build process, | ||
| # before any system packages or programming language specific package have been installed. | ||
| # | ||
| # Note: This file may be removed if you don't need to use it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| jupyterlab>3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Set environment variables in the format KEY=VALUE, 1 per line | ||
| # This file will be sourced inside the project container when started. | ||
| # NOTE: If you change this file while the project is running, you must restart the project container for changes to take effect. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/cuml
Length of output: 591
🌐 Web query:
official NVIDIA AI Workbench documentation variables.env sensitive variables secrets💡 Result:
NVIDIA AI Workbench distinguishes between non-sensitive environment variables and sensitive variables (secrets) to ensure secure management [1]. They are handled differently in terms of storage, version control, and accessibility [1][2]. Non-Sensitive Variables - Stored in the variables.env file within your project repository [1][3]. - These are version-controlled by Git and remain consistent across different hosts and users [1]. - They are intended for general configuration settings needed by your container [1]. Sensitive Variables (Secrets) - The keys and descriptions for secrets are defined in the project specification (.project/spec.yaml), which is version-controlled [4][5]. - The actual secret values are never stored in the repository [1][4]. Instead, they are stored securely on each host in a file named secrets.env located at.nvwb/project-runtime-info//secrets.env [1]. - Because these values live outside the repository, they must be re-entered when you clone a project to a new machine [4][6]. Managing Secrets via CLI - You can create a sensitive environment variable using the CLI command: nvwb create environment-variable --is-sensitive [7][8]. - You can set or update values for existing secrets using the nvwb configure secrets command [7]. - If you need to change a sensitive value, the existing secret must be deleted and created again, as sensitive variables cannot be directly mutated [8]. Security Considerations - AI Workbench stores project secrets unencrypted in the runtime directory on the host's disk [9]. This design is intended to be equivalent to how platforms like Docker and Podman manage secrets [9]. - These secrets are automatically deleted from the host when the corresponding project is removed from the context [9]. - Sensitive information, such as API keys or passwords, should always be configured as secrets rather than placed in variables.env to prevent them from being committed to source control [1].
Citations:
Sensitive Data Exposure
Reachability: Internal
Exploitability: Moderate
CWE: CWE-312 — Cleartext Storage of Sensitive Information
Keep secrets out of
variables.env.This tracked file is intended for non-sensitive values. Warn users not to add API keys, passwords, or other secrets, and direct them to AI Workbench sensitive variables.
Proposed clarification
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: MCP tools