Skip to content

Add optional timestamps enabled by env CUOPT_EXTRA_TIMESTAMPS #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2025
Merged

Add optional timestamps enabled by env CUOPT_EXTRA_TIMESTAMPS #392

merged 4 commits into from
Oct 3, 2025

Conversation

tmckayus
Copy link
Contributor

This change adds optional internal timestamps which can be enabled with env var CUOPT_EXTRA_TIMESTAMPS=True.

The timestamps are to allow benchmarking scripts to key off of the events in order to calculate problem setup and teardown time.

@tmckayus tmckayus requested review from a team as code owners September 15, 2025 15:02
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tmckayus tmckayus added feature request New feature or request non-breaking Introduces a non-breaking change labels Sep 15, 2025
@tmckayus
Copy link
Contributor Author

/ok to test b9bfccf

rgsl888prabhu
rgsl888prabhu requested changes Sep 15, 2025
View reviewed changes
@anandhkb anandhkb added this to the 25.10 milestone Sep 15, 2025
@tmckayus tmckayus requested a review from a team as a code owner September 16, 2025 19:28
@tmckayus
Copy link
Contributor Author

/ok to test 99c5ee9

KyleFromNVIDIA
KyleFromNVIDIA approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved trivial CMake changes

@rgsl888prabhu
Copy link
Collaborator

@rg20 @chris-maes May I get your review on this PR

aliceb-nv
aliceb-nv approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@aliceb-nv aliceb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving C++

@rgsl888prabhu
Copy link
Collaborator

/ok to test 9de0f56

@rgsl888prabhu
Copy link
Collaborator

/ok to test 92fa733

@aliceb-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit f4d6791 into NVIDIA:branch-25.10 Oct 3, 2025
172 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@aliceb-nv aliceb-nv aliceb-nv approved these changes

@rg20 rg20 Awaiting requested review from rg20 rg20 is a code owner automatically assigned from NVIDIA/cuopt-engine-codeowners

@chris-maes chris-maes Awaiting requested review from chris-maes chris-maes is a code owner automatically assigned from NVIDIA/cuopt-engine-codeowners

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
25.10
Development

Successfully merging this pull request may close these issues.
5 participants
@tmckayus @rgsl888prabhu @aliceb-nv @KyleFromNVIDIA @anandhkb