Add message when optimal solution is found during presolve #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg20
requested changes
Nov 24, 2025
Contributor
rg20
left a comment
rg20
left a comment
There was a problem hiding this comment.
Move the logic of checking if presolver found solution to presolve caller or presolve function itself.
Move the 'Optimal solution found during presolve' message to the presolve function itself (third_party_presolve.cpp) where we can accurately detect when presolve finds the optimal solution. This ensures the message only appears when presolve actually found the solution, not when the problem is empty for other reasons. Removed the message from generic empty problem checks in: - cpp/src/mip/solve.cu (run_mip function) - cpp/src/mip/solver.cu (run_solver function - both locations)
rg20
approved these changes
Nov 24, 2025
rg20
added
improvement
Contributor
|
/ok to test 527cd60 |
Collaborator
|
@adityasinghz Is this meant for 25.12 release or 26.02. If it is meant for 25.12, may I request you to close this PR and use branch release/25.12 branch as your base and create a PR? And also choose merge branch to be 25.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an explicit log message "Optimal solution found during presolve" that is displayed when the problem is fully reduced during presolve (i.e., when the problem is reduced to 0 constraints, 0 variables, and 0 nonzeros). This provides clear feedback to users that the optimal solution was discovered during presolve rather than through the main solving process.
Changes Made:
cpp/src/mip/solve.cu: Added log message whenproblem.emptyis true before running the MIP solvercpp/src/mip/solver.cu: Added log message in two locations:context.problem_ptr->emptyis true before running presolvecontext.problem_ptr->emptybecomes true after running presolveExample Output:
Before this change, when the optimal solution was found during presolve, users would see:
After this change, users will now see:
Issue #524
Checklist
I am familiar with the Contributing Guidelines.
Testing
Documentation