Skip to content

WIP: op is used instead of cur_op #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikeNano wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: op is used instead of cur_op #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/cuda/tile/_passes/token_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from cuda.tile._ir.type import TupleTy, TokenTy
from cuda.tile._memory_model import MemoryOrder
from cuda.tile._exception import Loc
from cuda.tile._exception import Loc, TileInternalError
from cuda.tile._ir.ir import Function, Block, IRContext, Var, Operation
from cuda.tile._ir.ops import (
Assign, Break, BuildTuple, CarriedVariables, Continue, EndBranch, IfElse,
Expand Down Expand Up @@ -150,15 +150,16 @@ def get_memory_effects(cur_op):

if isinstance(cur_op, LoadMemoryOperation):
effect = MemoryEffect.LOAD
else:
assert isinstance(cur_op, StoreMemoryOperation)
elif isinstance(cur_op, StoreMemoryOperation):
effect = MemoryEffect.STORE
else:
raise TileInternalError(f"Unexpected MemoryOperation type: {type(cur_op)}")

has_acquire_order = False
if isinstance(cur_op, (TileAtomicCAS, TileAtomicRMW)):
has_acquire_order = memory_order_has_acquire(op.memory_order)
has_acquire_order = memory_order_has_acquire(cur_op.memory_order)
Copy link
Contributor Author

@NikeNano NikeNano Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the outer or inner variable? I tried to read through the code and could not find any cases where we did not want the cur_op


return MemoryEffects({alias_result[_get_input_var(op).name]: effect}, has_acquire_order)
return MemoryEffects({alias_result[_get_input_var(cur_op).name]: effect}, has_acquire_order)

blk_mem_effects = EMPTY_MEMORY_EFFECTS
for op in block.operations:
Expand Down