enforce 'yamllint' checks, expand changed-files exclusions - #186
Conversation
| files_yaml: | | ||
| test_java: | ||
| - '**' | ||
| - '!.github/CODEOWNERS' |
There was a problem hiding this comment.
Proposing expanding this list, should help avoid some unnecessary CI runs.
| - id: check-symlinks | ||
| - id: check-xml | ||
| - repo: https://github.com/rapidsai/pre-commit-hooks | ||
| rev: v1.5.1 |
There was a problem hiding this comment.
I think this hook (and maybe others) might be outdated. Feel free to update as part of this PR if you wish.
There was a problem hiding this comment.
Yep it is (the latest is v1.6.1). I just did a pre-commit autoupdate and pushed the updates in b52d71a
The new hook versions didn't require any code changes, just the version bump.
|
Tests are failing like this: Guessing that's what this is trying to fix: #187 I think it'd be fine to admin-merge this change past those failures, once we have a |
|
I've merged in #187, we should hopefully CI pass here. |
|
Pushing an empty commit to re-trigger CI. @imotov mentioned to me that the failures we're seeing now may be caused by the delay in publishing There are now new packages from https://github.com/rapidsai/workflows/actions/runs/30462211108/job/90636110611 |
|
/merge |
…vs-lucene#186) Contributes to rapidsai/build-planning#305 Proposes enforcing `yamllint` checks here. My primary motivation is to catch correctness issues in `dependencies.yaml` files, like duplicate entries silently resolving to the last one or indentation mistakes leading to filters being ignored. But this also has some side benefits for consistency, which makes it a bit easier to write automation. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA/cuvs-lucene#186
3 participants
Description
Contributes to rapidsai/build-planning#305
Proposes enforcing
yamllintchecks here. My primary motivation is to catch correctness issues independencies.yamlfiles, like duplicate entries silently resolving to the last one or indentation mistakes leading to filters being ignored.But this also has some side benefits for consistency, which makes it a bit easier to write automation.