Forward-merge release/26.10 into main - #2571
Merged
Merged
Conversation
Move java/examples and java/cuvs-lucene/examples to examples/java/cuvs-java and examples/java/cuvs-lucene, matching the existing examples for C, C++ and Go. Add a --build-java-examples flag to build.sh, java/build.sh, and java/cuvs-lucene/build.sh that compiles the examples against the jar just built, and wire it into ci/build_java.sh/ci/build_lucene.sh so CI catches drift between the examples and the cuvs-java/cuvs-lucene API. Fix the examples themselves, which had silently drifted from the current API (builder signatures now require CuVSResources, destroyIndex() -> close(), CagraQuery needs a CuVSMatrix, and CAGRA search now requires an explicit device-padded dataset). Closes #2448 Closes #2542 Authors: - Igor Motov (https://github.com/imotov) Approvers: - James Lamb (https://github.com/jameslamb) - MithunR (https://github.com/mythrocks) URL: #2543
Contributor
Author
|
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.10 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.