Improve CAGRA multi-CTA heuristic: max_iterations - #2582
Open
sherylll wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For multi-CTA mode, current
max_iterationsis assigned a large number. However, at lowitopk, extra iterations only add latency and does not do much to recall. So the intuition is to use a lowermax_iterationsfor smalleritopk.minimum_depth = 8 * (search_quality - 1), since we don't provide a knob forsearch_qualityfor the moment, hardcoding this to 16.search_quality = 5would mean the previous default 32.When the problem is harder, or when more results are needed, it is still a good idea to turn up the
max_iterations.n_queries=1,k=10n_queries=10,k=50This is a subset of #2502, where the change to width or hashmap size seem to have different effect on different GPU generations, which still remains to be investigated. But the conclusion on
max_iterationsshould hold.