docs-build: switch to RTX Pro 6000, add changed-files filter - #2584
Open
jameslamb wants to merge 2 commits into
Open
docs-build: switch to RTX Pro 6000, add changed-files filter#2584jameslamb wants to merge 2 commits into
jameslamb wants to merge 2 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
16 tasks
jameslamb
commented
Sep 10, 2026
| pull-requests: read | ||
| secrets: inherit # zizmor: ignore[secrets-inherit] | ||
| uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@release/26.10 | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).build_docs |
Member
Author
There was a problem hiding this comment.
This looked like an omission, given that there's configuration for it:
cuvs/.github/workflows/pr.yaml
Lines 86 to 89 in 29e1101
This fixes that, so some types of PRs that don't affect the docs will not have a docs CI job.
jameslamb
commented
Sep 10, 2026
| build_type: pull-request | ||
| matrix_name: docs-build | ||
| docs-build: | ||
| needs: [docs-build-matrix] |
Member
Author
There was a problem hiding this comment.
I was surprised to not see any conda packages needed for the docs builds, but looks like that was an intentional change in #2067
jameslamb
marked this pull request as ready for review
September 10, 2026 02:53
gforsyth
approved these changes
Sep 10, 2026
jameslamb
force-pushed
the
docs-build-runners
branch
from
September 10, 2026 13:32
517d2a4 to
9325e2e
Compare
jameslamb
marked this pull request as draft
September 10, 2026 13:41
jameslamb
marked this pull request as ready for review
September 10, 2026 13:41
bdice
approved these changes
Sep 10, 2026
Member
Author
|
/merge |
Member
Author
|
One C++ test failure: Re-trying. cc @aamijar for your tracking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#333
Updates to hopefully reduce how often
docs-buildjobs get stuck waiting for CI runners.docs-buildmatrix to set job detailsAlso noticed that there's a
docs_buildgroup in thechanged-filesconfiguration, but it isn't used to limit when docs builds runs. This adds that as well.Notes for Reviewers
CI will pass here once rapidsai/shared-workflows#627 is merged.