Skip to content

Increase max metadata value size to 2KB #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diwu1989 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase max metadata value size to 2KB #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions swift/swift.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@
# random unique strings that can never change (DO NOT LOSE)
swift_hash_path_prefix = veDDnRGXVW7rXqc3
swift_hash_path_suffix = 0rBOk3EM17yId7Ke

[swift-constraints]
max_meta_value_length = 2048
Copy link
Contributor

@timuralp timuralp Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to make Swift constraints match S3, there are a few more relevant settings: https://github.com/openstack/swift/blob/master/swift/common/constraints.py

Specifically, I think you want to set max_meta_overall_size to 2048 and max_meta_header_size to 2048. It looks like S3 doesn't have a hard constraint on the length of the metadata key either (at least I can't find it here: https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html#object-metadata), so maybe max_meta_name_length should also be 2048. Can you validate the various lengths against AWS S3? I'm also unclear if there is a maximum number of x-amz-meta- headers allowed (which Swift currently sets to 90).