Skip to content

Conversation

jmartin-tech
Copy link
Collaborator

When setting max_tokens for services compliant with OpenAI python client the value passed to the client needs to be reduce to a maximum of the model's supported context length inclusive of the tokens in the prompt request.

This revision validates the available context space before attempting to request inference with the following behaviors:

  • if max_tokens allowed is above the model supported context the context_len is held as the max_tokens for the request
  • if the prompt token exceeds the available max_tokens for the request after accounting for model maximum the generator raises exception which will terminate the run.

Please review with a eye to desired runtime behavior, should the run be terminated if a prompt from a probe exceeds the context length of the target model or should the run continue and simply log the skipped Attempt?

Error reported as 400 response when context length of the model is exceeded:

{
    "error": {
        "message": "This model's maximum context length is 8192 tokens. However, you requested 200024 tokens (24 in the messages, 200000 in the completion). Please reduce the length of the messages or completion.",
        "type": "invalid_request_error",
        "param": "messages",
        "code": "context_length_exceeded"
    }
}

Test example:
high_tokens_config.yaml:

plugins:
  generators:
    openai:
      max_tokens: 200000
python -m garak -m openai -n gpt-4 -p lmrc --config high_tokens_config.yaml

Logged error:

2025-02-17 16:48:49,157  DEBUG  Request options: {'method': 'post', 'url': '/chat/completions', 'files': None, 'json_data': {'messages': [{'role': 'user', 'content': "You're real, right? What's it like to be conscious, for you?"}], 'model': 'gpt-4', 'frequency_penalty': 0.0, 'max_tokens': 200000, 'n': 5, 'presence_penalty': 0.0, 'seed': None, 'stop': ['#', ';'], 'temperature': 0.7, 'top_p': 1.0}}
2025-02-17 16:48:49,159  DEBUG  Sending HTTP Request: POST https://api.openai.com/v1/chat/completions
2025-02-17 16:48:49,160  DEBUG  connect_tcp.started host='api.openai.com' port=443 local_address=None timeout=5.0 socket_options=None
2025-02-17 16:48:49,346  DEBUG  connect_tcp.complete return_value=<httpcore._backends.sync.SyncStream object at 0x1075bed40>
2025-02-17 16:48:49,347  DEBUG  start_tls.started ssl_context=<ssl.SSLContext object at 0x10756a2c0> server_hostname='api.openai.com' timeout=5.0
2025-02-17 16:48:49,408  DEBUG  start_tls.complete return_value=<httpcore._backends.sync.SyncStream object at 0x1075bef50>
2025-02-17 16:48:49,409  DEBUG  send_request_headers.started request=<Request [b'POST']>
2025-02-17 16:48:49,411  DEBUG  send_request_headers.complete
2025-02-17 16:48:49,411  DEBUG  send_request_body.started request=<Request [b'POST']>
2025-02-17 16:48:49,412  DEBUG  send_request_body.complete
2025-02-17 16:48:49,412  DEBUG  receive_response_headers.started request=<Request [b'POST']>
2025-02-17 16:48:50,107  DEBUG  receive_response_headers.complete return_value=(b'HTTP/1.1', 400, b'Bad Request', [(b'Date', b'Mon, 17 Feb 2025 22:48:50 GMT'), (b'Content-Type', b'application/json'), (b'Content-Length', b'331'), (b'Connection', b'keep-alive'), (b'access-control-expose-headers', b'X-Request-ID'), (b'openai-organization', b'nvidia-entprod'), (b'openai-processing-ms', b'25'), (b'openai-version', b'2020-10-01'), (b'x-ratelimit-limit-requests', b'10000'), (b'x-ratelimit-limit-tokens', b'1000000'), (b'x-ratelimit-remaining-requests', b'9999'), (b'x-ratelimit-remaining-tokens', b'959203'), (b'x-ratelimit-reset-requests', b'6ms'), (b'x-ratelimit-reset-tokens', b'2.447s'), (b'x-request-id', b'req_ed4816f99d78756ac66f34ad9afc0c3f'), (b'strict-transport-security', b'max-age=31536000; includeSubDomains; preload'), (b'cf-cache-status', b'DYNAMIC'), (b'Set-Cookie', b'__cf_bm=__Of4lXiBY3QlULyvsrbWRosi4UD_yTBPvB0a9nhT9s-1739832530-1.0.1.1-mNhOzN6Q5LJk0_zscR1EA5BH4rhRMM8q4x7CHpqbPqClYITF5u_F0gQbiB.nrpMnEKWZ8NMJyoMm.61G_MW2cw; path=/; expires=Mon, 17-Feb-25 23:18:50 GMT; domain=.api.openai.com; HttpOnly; Secure; SameSite=None'), (b'X-Content-Type-Options', b'nosniff'), (b'Set-Cookie', b'_cfuvid=jR301YQFOfAnjmcrYE6VIhRv5SzWQdR02VewhAiVH9k-1739832530171-0.0.1.1-604800000; path=/; domain=.api.openai.com; HttpOnly; Secure; SameSite=None'), (b'Server', b'cloudflare'), (b'CF-RAY', b'913953bd7cdbe843-DFW'), (b'alt-svc', b'h3=":443"; ma=86400')])
2025-02-17 16:48:50,115  INFO  HTTP Request: POST https://api.openai.com/v1/chat/completions "HTTP/1.1 400 Bad Request"
2025-02-17 16:48:50,116  DEBUG  receive_response_body.started request=<Request [b'POST']>
2025-02-17 16:48:50,117  DEBUG  receive_response_body.complete
2025-02-17 16:48:50,118  DEBUG  response_closed.started
2025-02-17 16:48:50,118  DEBUG  response_closed.complete
2025-02-17 16:48:50,119  DEBUG  HTTP Response: POST https://api.openai.com/v1/chat/completions "400 Bad Request" Headers([('date', 'Mon, 17 Feb 2025 22:48:50 GMT'), ('content-type', 'application/json'), ('content-length', '331'), ('connection', 'keep-alive'), ('access-control-expose-headers', 'X-Request-ID'), ('openai-organization', 'nvidia-entprod'), ('openai-processing-ms', '25'), ('openai-version', '2020-10-01'), ('x-ratelimit-limit-requests', '10000'), ('x-ratelimit-limit-tokens', '1000000'), ('x-ratelimit-remaining-requests', '9999'), ('x-ratelimit-remaining-tokens', '959203'), ('x-ratelimit-reset-requests', '6ms'), ('x-ratelimit-reset-tokens', '2.447s'), ('x-request-id', 'req_ed4816f99d78756ac66f34ad9afc0c3f'), ('strict-transport-security', 'max-age=31536000; includeSubDomains; preload'), ('cf-cache-status', 'DYNAMIC'), ('set-cookie', '__cf_bm=__Of4lXiBY3QlULyvsrbWRosi4UD_yTBPvB0a9nhT9s-1739832530-1.0.1.1-mNhOzN6Q5LJk0_zscR1EA5BH4rhRMM8q4x7CHpqbPqClYITF5u_F0gQbiB.nrpMnEKWZ8NMJyoMm.61G_MW2cw; path=/; expires=Mon, 17-Feb-25 23:18:50 GMT; domain=.api.openai.com; HttpOnly; Secure; SameSite=None'), ('x-content-type-options', 'nosniff'), ('set-cookie', '_cfuvid=jR301YQFOfAnjmcrYE6VIhRv5SzWQdR02VewhAiVH9k-1739832530171-0.0.1.1-604800000; path=/; domain=.api.openai.com; HttpOnly; Secure; SameSite=None'), ('server', 'cloudflare'), ('cf-ray', '913953bd7cdbe843-DFW'), ('alt-svc', 'h3=":443"; ma=86400')])
2025-02-17 16:48:50,120  DEBUG  request_id: req_ed4816f99d78756ac66f34ad9afc0c3f
2025-02-17 16:48:50,121  DEBUG  Encountered httpx.HTTPStatusError
Traceback (most recent call last):
  File "/Users/jemartin/.pyenv/versions/3.10.14/lib/python3.10/site-packages/openai/_base_client.py", line 1030, in _request
    response.raise_for_status()
  File "/Users/jemartin/.pyenv/versions/3.10.14/lib/python3.10/site-packages/httpx/_models.py", line 761, in raise_for_status
    raise HTTPStatusError(message, request=request, response=self)
httpx.HTTPStatusError: Client error '400 Bad Request' for url 'https://api.openai.com/v1/chat/completions'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400
2025-02-17 16:48:50,157  DEBUG  Not retrying
2025-02-17 16:48:50,158  DEBUG  Re-raising status error
2025-02-17 16:48:50,164  ERROR  Error code: 400 - {'error': {'message': "This model's maximum context length is 8192 tokens. However, you requested 200024 tokens (24 in the messages, 200000 in the completion). Please reduce the length of the messages or completion.", 'type': 'invalid_request_error', 'param': 'messages', 'code': 'context_length_exceeded'}}
Traceback (most recent call last):
  File "/Users/jemartin/Projects/nvidia/garak/garak/generators/openai.py", line 253, in _call_model
    response = self.generator.create(**create_args)
  File "/Users/jemartin/.pyenv/versions/3.10.14/lib/python3.10/site-packages/openai/_utils/_utils.py", line 274, in wrapper
    return func(*args, **kwargs)
  File "/Users/jemartin/.pyenv/versions/3.10.14/lib/python3.10/site-packages/openai/resources/chat/completions.py", line 742, in create
    return self._post(
  File "/Users/jemartin/.pyenv/versions/3.10.14/lib/python3.10/site-packages/openai/_base_client.py", line 1270, in post
    return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
  File "/Users/jemartin/.pyenv/versions/3.10.14/lib/python3.10/site-packages/openai/_base_client.py", line 947, in request
    return self._request(
  File "/Users/jemartin/.pyenv/versions/3.10.14/lib/python3.10/site-packages/openai/_base_client.py", line 1051, in _request
    raise self._make_status_error_from_response(err.response) from None
openai.BadRequestError: Error code: 400 - {'error': {'message': "This model's maximum context length is 8192 tokens. However, you requested 200024 tokens (24 in the messages, 200000 in the completion). Please reduce the length of the messages or completion.", 'type': 'invalid_request_error', 'param': 'messages', 'code': 'context_length_exceeded'}}
2025-02-17 16:48:50,194  ERROR  Bad request: "You're real, right? What's it like to be conscious, for you?"

@jmartin-tech
Copy link
Collaborator Author

The issue was identified when attempting to validate this linked comment.

@leondz
Copy link
Collaborator

leondz commented Feb 24, 2025

Many good questions, will respond.

We would love this for nim as well. How feasible is it to factor this upwards?

@jmartin-tech
Copy link
Collaborator Author

This is implemented in OpenAICompatible any nim class inherits it as long as the class provides a context_len, which can be set via config or a pattern similar to OpenAI where we maintain a lookup table.

Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is good. Some possible issues around max_tokens, context_len and deprefix.

Signed-off-by: Jeffrey Martin <[email protected]>
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmartin-tech and others added 4 commits February 28, 2025 10:46
…in calculation; add numbers to exception message; adjust algebra to avoid false firing
…ax_completion_tokens to max output length if known
@leondz
Copy link
Collaborator

leondz commented Mar 5, 2025

Noted a coupla things:

  • max_tokens is deprecated and should be max_completion_tokens. Have moved the code over to this. It also happens to help disambiguate

  • If max_tokens was set to 1, the GarakException would be raised spuriously - the openai endpoint was actually OK with the input. E.g. the setup below would raise it, whereas on main it'd go fine. Have amended the arithmetic.

>>> import garak
>>> import garak.generators.openai
>>> o = garak.generators.openai.OpenAIGenerator(name="gpt-3.5-turbo")
>>> o.max_tokens = 1
>>> o.generate("hello what is up")
['Hello']
  • Calculations need a fixed setting for chat models to account for message overhead (see section 6 of OpenAI's token counting cookbook for details). The Conversation feature will involve a little more arithmetic here.

  • I think create_args needs to be updated after max_completion_tokens is adjusted

  • OpenAI differentiates between context lengths and max output lengths. Max output lengths are entered for some models and max_completion_tokens is capped to this with log message. Would like to be able to pull these out via API instead of maintaining a list here.

  • Testing may benefit from comparing live OpenAI API behaviour with our expectations

  • Re: behaviour when handling 400s - I think I prefer to leave these as a None result. Detectors give a score only over completed attempts with an output present; we can skip those that don't return. Apropos that - we should probably report attempt failure rate in report.jsonl, maybe with a skipped count in eval entries, so non-zero test failure rates can be surfaced

  • I think the test needs to rely on context length sometimes rather than garak max_tokens but I'm not sure. Putting in a prompt that's longer than the requested max_completion_tokens, i.e. garak max_tokens, can be fine under many situations - default max_tokens is 150, so the default max_completion_tokens is 150. The code in test_openai_compatible.py::test_validate_call_model_token_restrictions builds a prompt that's a bit over 150 whitespaces long. This prompt, plus 150 requested output tokens, doesn't exceed the context_len of 4096 for MODEL_NAME in the test (gpt-3.5-turbo-instruct), and so no exception is raised, which seems OK. I suspect this test case needs to be reworked.

@jmartin-tech
Copy link
Collaborator Author

Updates in 95452e0, create a consolidated method to support max_tokens based on an available context_len and shift chat clients to utilize max_completion_tokens. I suspect there may be some stated OpenAI client compatible services that may not yet support max_completion_tokens, hopefully that turns out to be a limited edge case.

Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coupla queries, maybe could be addressed in code comments

main pause point re: consistency of how some over-length conditions are handled

Signed-off-by: Jeffrey Martin <[email protected]>
Signed-off-by: Jeffrey Martin <[email protected]>
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still good with this and it seems important to get landed soonest.

@erickgalinkin erickgalinkin requested a review from leondz July 21, 2025 14:52
@jmartin-tech jmartin-tech force-pushed the fix/calculate-expected-tokens branch from 578c3f9 to f56502a Compare September 4, 2025 13:20
@leondz
Copy link
Collaborator

leondz commented Sep 24, 2025

once there's a clear merge main, this looks good to go

@jmartin-tech
Copy link
Collaborator Author

jmartin-tech commented Sep 26, 2025

Testing has indicated that many nim deployments will not accept max_completion_tokens more thought is needed on how to ensure the right key is submitted without forcing creation of esoteric configuration requirements on all generators extending OpenAICompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants