mount imex nodes config #1080
Open
mount imex nodes config #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptaNswati
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
cdesiniotis
reviewed
Oct 29, 2024
| - name: host-imex-config | ||
| hostPath: | ||
| path: /etc/nvidia-imex/nodes_config.cfg | ||
| type: File |
There was a problem hiding this comment.
We can't unconditionally mount this file as most systems don't have IMEX installed, and thus, this file won't exist. I am also opposed to configuring this volume as FileOrCreate, as that would cause this file to be unnecessarily created on all GPU nodes.
We may want to consider the approach we are leveraging in GFD. That is, mount the host's /etc in an init container, and if /host/etc/nvidia-imex/nodes_config.cfg exists, copy this file to an emptyDir volume that is shared with the main driver container. Unlike in GFD, we can mount this shared emptyDir volume to /etc/nvidia-imex in the driver container.
There was a problem hiding this comment.
Yes make sense.
guptaNswati
force-pushed
the
mount-imex-config
branch
from
8fcb4dc
to
59c4bf5
Compare
tariq1890
reviewed
Oct 31, 2024
guptaNswati
force-pushed
the
mount-imex-config
branch
4 times, most recently
from
4fa5aca
to
ef20f1b
Compare
lint fixes
guptaNswati
force-pushed
the
mount-imex-config
branch
from
0a9f8ee
to
ba6e69b
Compare
|
/ok to test |
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.