Bump NFD to v0.16.0 #735
Draft
Bump NFD to v0.16.0 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesiniotis
commented
Jun 8, 2024
| namespace: {{ include "node-feature-discovery.namespace" . }} | ||
| --- | ||
| apiVersion: batch/v1 | ||
| kind: Job |
There was a problem hiding this comment.
From the v0.16.0 release notes:
Helm Chart
Now all nodes are cleaned up (feature labels, annotations, extended resources and taints are removed) after uninstalling NFD using a post-delete hook.
I suspect this post-delete hook is what is causing our e2e tests to fail. We are hitting a timeout waiting for a condition when uninstalling the GPU Operator.
Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
force-pushed
the
bump-nfd-0.16.0
branch
from
4f77a05
to
f1f0eb8
Compare
|
I have verified that this changeset fixes the e2e failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.