Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/node-feature-discovery from 0.14.2 to 0.15.1 #485

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 28, 2024

Bumps sigs.k8s.io/node-feature-discovery from 0.14.2 to 0.15.1.

Release notes

Sourced from sigs.k8s.io/node-feature-discovery's releases.

v0.15.1

What's Changed

This patch release adds detection of speed attribute of virtual network interfaces.

List of PRs

  • makefile: fix build: target (#1529)
  • source/network: discover speed of virtual network interfaces (#1538)

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.0...v0.15.1

v0.15.0

What's new

NodeFeatureRule API extended

Annotations

NFD now supports creating node annotations with the NodeFeatureRuless. See the documentation for details.

matchName

New matchName field was added to the NodeFeatureRule CRD. It can be used to match the names of features (instead of their values which is done with the matchExpressions field). See documentation for details.

Feature files

Hidden feature files: feature files whose name start with a dot (.) are now ignored by nfd-worker. This makes it easier to update the feature files by creating a temporary file in the same directory. (#1353)

Skip labels or features: Feature files support # +no-label and # +no-feature directives to skip label and feature generation, respectively. See the documentation for details and examples.

Container image based on scratch

NFD switched to use scratch as the base container image and to build fully statically linked binaries. Switching to the virtually empty base image means that the default container image only supports running hooks that are also fully statically linked. For example, many go binaries that are "almost" statically linked don't work. The full image variant can be used for richer hook support. NOTE: hooks are deprecated and support for them will be removed in a future release.

Base image of the full image variant was updated to Debian Bookworm.

Discover virtual network interfaces

NFD now discovers virtual network interfaces as features that can be used in NodeFeatureRules. (#1448)

Kubectl plugin

Starting as a developer preview, we are introducing a kubectl-nfd plugin to perform 3 operations against NodeFeatureRule files. (#1446)

  • test: Check a NodeFeatureRule file against a node to ensure it is valid before applying it to a cluster.
  • dryrun: Check a NodeFeatureRule file against a local NodeFeature file, allowing an offline testing of the rule to be before applying it to a cluster.
  • validate: Check if the NodeFeatureRule file will valid and can be used against NodeFeatures.

... (truncated)

Commits
  • 89aff13 Merge pull request #1544 from marquiz/release-0.15
  • 6f18cd2 Update references to release v0.15.1
  • 7152c91 Merge pull request #1538 from k8s-infra-cherrypick-robot/cherry-pick-1536-to-...
  • 85197fc source/network: discover speed of virtual network interfaces
  • 8d74fc1 Merge pull request #1529 from k8s-infra-cherrypick-robot/cherry-pick-1528-to-...
  • 1feceb4 makefile: fix build: target
  • dc34a69 Merge pull request #1522 from marquiz/release-0.15
  • 3391201 Merge pull request #1525 from k8s-infra-cherrypick-robot/cherry-pick-1523-to-...
  • a46be97 deployment/kustomize: enable nfd-gc in the default overlay
  • 0c3f5f3 Update references to release v0.15.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch 2 times, most recently from 7652d42 to 3d3d1a8 Compare January 28, 2024 18:31
@ArangoGutierrez
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch 2 times, most recently from 35399ff to 2302fb3 Compare January 28, 2024 18:34
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch 2 times, most recently from b8c1054 to b78f236 Compare February 6, 2024 10:46
@elezar
Copy link
Member

elezar commented Feb 14, 2024

@ArangoGutierrez this is blocked by a k8s update. It might be better to address that separately.

I know that @tariq1890 mentioned some issues with Pod Security Policies and I'm not sure if that affects this at all.

@tariq1890
Copy link
Contributor

@elezar It looks like you need to update the go version here.

The k8s v1.29 should only affect you if you're using the PodSecurityPolicy API. I am not sure if that is the case with the device-plugin

@elezar
Copy link
Member

elezar commented Feb 15, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch 2 times, most recently from ed8b167 to a9e08ee Compare February 15, 2024 16:45
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch 2 times, most recently from 1d18846 to d3532b6 Compare February 26, 2024 14:07
@ArangoGutierrez
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch 2 times, most recently from 2ef1dbf to d9b0f91 Compare February 27, 2024 13:52
go.mod Outdated
@@ -1,6 +1,7 @@
module github.com/NVIDIA/k8s-device-plugin

go 1.21
toolchain go1.22.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArangoGutierrez this is probably because of the versions in NFD. Since NFD is consumed by so many clients, does it make sense to drop the go version there slightly?

@elezar elezar force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch from d9b0f91 to ebb923e Compare February 27, 2024 15:08
@elezar
Copy link
Member

elezar commented Feb 27, 2024

@ArangoGutierrez I have rebased this off #559 to verify that those changes are sane and address the failures we're seeing here.

@@ -531,8 +531,6 @@ k8s.io/kubectl v0.29.2 h1:uaDYaBhumvkwz0S2XHt36fK0v5IdNgL7HyUniwb2IUo=
k8s.io/kubectl v0.29.2/go.mod h1:BhizuYBGcKaHWyq+G7txGw2fXg576QbPrrnQdQDZgqI=
k8s.io/kubelet v0.29.2 h1:bQ2StqkUqPCFNLtGLsb3v3O2LKQHXNMju537zOGboRg=
k8s.io/kubelet v0.29.2/go.mod h1:i5orNPqW/fAMrqptbCXFW/vLBBP12TZZc41IrrvF7SY=
k8s.io/kubernetes v1.28.7 h1:XV7AiCqtuOLaERR7uWcJnVpGG090lzJ9A37ftQuJhN4=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArangoGutierrez it seems we don't need this dependency anymore.

We should also remove the replace rule then.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just mean the single replace rule for now.

Copy link
Member

@elezar elezar Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in latest. will do as a follow-up.

@ArangoGutierrez ArangoGutierrez added the dependencies Issue/PR Pull about a dependency file label Feb 27, 2024
@ArangoGutierrez ArangoGutierrez self-assigned this Feb 27, 2024
@elezar elezar force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch 2 times, most recently from 0b266de to 8e528b1 Compare February 27, 2024 16:00
@elezar
Copy link
Member

elezar commented Feb 27, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch from 8e528b1 to 357d3e9 Compare February 27, 2024 17:08
Bumps [sigs.k8s.io/node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) from 0.14.2 to 0.15.1.
- [Release notes](https://github.com/kubernetes-sigs/node-feature-discovery/releases)
- [Commits](kubernetes-sigs/node-feature-discovery@v0.14.2...v0.15.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/node-feature-discovery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@elezar elezar force-pushed the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch from 357d3e9 to 4877a01 Compare February 27, 2024 17:09
@ArangoGutierrez ArangoGutierrez merged commit 70b8c29 into main Feb 27, 2024
6 checks passed
@ArangoGutierrez ArangoGutierrez deleted the dependabot/go_modules/main/sigs.k8s.io/node-feature-discovery-0.15.1 branch February 27, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue/PR Pull about a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants