-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/node-feature-discovery from 0.14.2 to 0.15.1 #485
Bump sigs.k8s.io/node-feature-discovery from 0.14.2 to 0.15.1 #485
Conversation
7652d42
to
3d3d1a8
Compare
@dependabot recreate |
35399ff
to
2302fb3
Compare
b8c1054
to
b78f236
Compare
@ArangoGutierrez this is blocked by a k8s update. It might be better to address that separately. I know that @tariq1890 mentioned some issues with Pod Security Policies and I'm not sure if that affects this at all. |
@elezar It looks like you need to update the go version here. The k8s v1.29 should only affect you if you're using the PodSecurityPolicy API. I am not sure if that is the case with the device-plugin |
@dependabot rebase |
ed8b167
to
a9e08ee
Compare
1d18846
to
d3532b6
Compare
@dependabot recreate |
2ef1dbf
to
d9b0f91
Compare
go.mod
Outdated
@@ -1,6 +1,7 @@ | |||
module github.com/NVIDIA/k8s-device-plugin | |||
|
|||
go 1.21 | |||
toolchain go1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArangoGutierrez this is probably because of the versions in NFD. Since NFD is consumed by so many clients, does it make sense to drop the go version there slightly?
d9b0f91
to
ebb923e
Compare
@ArangoGutierrez I have rebased this off #559 to verify that those changes are sane and address the failures we're seeing here. |
@@ -531,8 +531,6 @@ k8s.io/kubectl v0.29.2 h1:uaDYaBhumvkwz0S2XHt36fK0v5IdNgL7HyUniwb2IUo= | |||
k8s.io/kubectl v0.29.2/go.mod h1:BhizuYBGcKaHWyq+G7txGw2fXg576QbPrrnQdQDZgqI= | |||
k8s.io/kubelet v0.29.2 h1:bQ2StqkUqPCFNLtGLsb3v3O2LKQHXNMju537zOGboRg= | |||
k8s.io/kubelet v0.29.2/go.mod h1:i5orNPqW/fAMrqptbCXFW/vLBBP12TZZc41IrrvF7SY= | |||
k8s.io/kubernetes v1.28.7 h1:XV7AiCqtuOLaERR7uWcJnVpGG090lzJ9A37ftQuJhN4= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArangoGutierrez it seems we don't need this dependency anymore.
We should also remove the replace rule then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just mean the single replace rule for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in latest. will do as a follow-up.
0b266de
to
8e528b1
Compare
@dependabot recreate |
8e528b1
to
357d3e9
Compare
Bumps [sigs.k8s.io/node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) from 0.14.2 to 0.15.1. - [Release notes](https://github.com/kubernetes-sigs/node-feature-discovery/releases) - [Commits](kubernetes-sigs/node-feature-discovery@v0.14.2...v0.15.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/node-feature-discovery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
357d3e9
to
4877a01
Compare
Bumps sigs.k8s.io/node-feature-discovery from 0.14.2 to 0.15.1.
Release notes
Sourced from sigs.k8s.io/node-feature-discovery's releases.
... (truncated)
Commits
89aff13
Merge pull request #1544 from marquiz/release-0.156f18cd2
Update references to release v0.15.17152c91
Merge pull request #1538 from k8s-infra-cherrypick-robot/cherry-pick-1536-to-...85197fc
source/network: discover speed of virtual network interfaces8d74fc1
Merge pull request #1529 from k8s-infra-cherrypick-robot/cherry-pick-1528-to-...1feceb4
makefile: fix build: targetdc34a69
Merge pull request #1522 from marquiz/release-0.153391201
Merge pull request #1525 from k8s-infra-cherrypick-robot/cherry-pick-1523-to-...a46be97
deployment/kustomize: enable nfd-gc in the default overlay0c3f5f3
Update references to release v0.15.0You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)