Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NIMService status with model information #346

Merged
merged 9 commits into from
Mar 3, 2025
Merged

Update NIMService status with model information #346

merged 9 commits into from
Mar 3, 2025

Conversation

varunrsekar
Copy link
Collaborator

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 25, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@varunrsekar varunrsekar changed the title Draft: Update NIMService status with model information Update NIMService status with model information Feb 28, 2025
@varunrsekar @shivamerla
add model info to nimservice status
cec23ba 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
use clusterip for model endpoint
db7b2bd 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
fetch model info from nimsrevice
45cc482 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
move models requests to separate package
8249b9c 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
unit tests for nimservice status api
dfa4a2b 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
reflect both cluster + external endpoint for nimservice
4957a7d 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
identify model name when lora adapters are present
c94c587 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
fix linter errors
7c7639e 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar @shivamerla
set ingress endpoints in status when available
f5d6187 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
shivamerla
shivamerla approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamerla shivamerla merged commit 85d4858 into NVIDIA:main Mar 3, 2025
9 checks passed
@varunrsekar varunrsekar deleted the nim-status branch April 1, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamerla shivamerla shivamerla approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@slu2011 slu2011 Awaiting requested review from slu2011 slu2011 is a code owner

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunrsekar @shivamerla