Replace eval() in LooGLE evaluation parsing#248
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval()in the LooGLE cloze metrics with safe JSON/literal parsingqa_pairswhen building the LooGLE Hugging Face datasetRoot cause
The LooGLE benchmark parsed both dataset fields and generated answers with
eval(). Forshortdep_cloze, that meant a crafted prediction string could execute Python during metric calculation.Validation
uv run --python 3.11 pytest tests/test_loogle_parsing.pyuv run --python 3.11 flake8 evaluation/benchmarks/loogle/calculate_metrics.py evaluation/benchmarks/loogle/create_huggingface_dataset.py evaluation/benchmarks/loogle/parsing.py tests/test_loogle_parsing.pyuv run --python 3.11 mypy evaluation/benchmarks/loogle/calculate_metrics.py evaluation/benchmarks/loogle/create_huggingface_dataset.py evaluation/benchmarks/loogle/parsing.py tests/test_loogle_parsing.py --check-untyped-defsuv run --python 3.11 python -c "import evaluation.benchmarks.loogle.create_huggingface_dataset as mod; print("import-ok", hasattr(mod, "build_task_dataframe"), hasattr(mod, "main"))"