-
Notifications
You must be signed in to change notification settings - Fork 50
Extend the functionality of apply-exit to refresh CDI config #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8eff22b to
d671054
Compare
deployments/systemd/hooks.sh
Outdated
| fi | ||
| } | ||
|
|
||
| function refresh-cdi-config() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
cf9c0bd to
83b4d05
Compare
83b4d05 to
97b7f03
Compare
|
@ArangoGutierrez how are we specifying WHERE the output should be created? Although @klueska had concerns about triggering the Also, on:
I don't think that specifying an output path in the config file makes sense since this would complicate the default behvaiour which is to output the spec to STDOUT. |
I would like to call the |
97b7f03 to
077807f
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
077807f to
e624ef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the apply-exit hook functionality to refresh CDI (Container Device Interface) configuration after MIG reconfiguration events. The implementation adds a new hook that triggers CDI configuration updates through a systemd service.
Key changes:
- Adds a new
cdi-refreshhook to the hooks configuration - Creates a new script that conditionally starts the nvidia-cdi-refresh systemd service
- Integrates CDI refresh functionality into the MIG manager's hook system
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| deployments/systemd/hooks-default.yaml | Adds new cdi-refresh hook configuration that executes the CDI refresh script |
| deployments/systemd/cdi-refresh.sh | New shell script that conditionally starts nvidia-cdi-refresh.service if available |
This patch adds extra functionality to the
apply-exithook, calling thenvidia-ctk cdi generateto refresh the CDI config on a MIG (re)configuration event