[mig-manager] move library/nvidia-smi discovery logic to Go #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Thanks @cdesiniotis.
It would be better if we move away from global variables here -- especially for the new code.
| q ) # process option q | ||
| NVIDIA_SMI_PATH=${OPTARG} | ||
| ;; | ||
| \? ) echo "Usage: ${0} -n <node> -f <config-file> -c <selected-config> -p <default-gpu-clients-namespace> [-e -t <driver-root> -a <driver-root-ctr-path> -b <dev-root> -j <dev-root-ctr-path> -l <driver-library-path> -q <nvidia-smi-path> ] [ -m <host-root-mount> -i <host-nvidia-dir> -o <host-mig-manager-state-file> -g <host-gpu-client-services> -k <host-kubelet-service> -r -s ]" |
There was a problem hiding this comment.
Any reason why we don't call usage and exit here? (like we do for h)
There was a problem hiding this comment.
I am not aware of any reason not to. I can update this to call usage and exit in a follow-up.
Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
force-pushed
the
move-file-discovery-to-go
branch
from
12fab2e to
f8b0c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.