fix(examples): add resource limits to Helm workload samples - #1889
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe task and inference Helm samples now define configurable CPU and memory requests and limits. Their workloads render these resources. Chart versions and documentation now reflect the updated configuration. ChangesHelm resource enforcement
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The sample charts now provide configurable resource requests and limits as intended, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation For Resolution Add the linked Full details: Out of Scope Changes checkExplanation The changes under
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Closes #1887 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
5973f22 to
f6bcd19
Compare
TL;DR
Add default CPU and memory requests and limits to the Helm task and function
samples so current self-managed admission validation accepts both workloads.
Additional Details
The self-managed compute-plane stack enables Helm task and function resource
enforcement by default. Both public sample charts omitted container resources,
so users could create the API objects but the compute plane rejected the
rendered workloads during admission.
This change:
resourcesvalues with small CPU and memory defaults toboth charts
No third-party dependencies were added. No license or NOTICE changes are
required.
For the Reviewer
Please review the default resource sizing and the template indentation in the
task Job and function Deployment.
For QA
Validated with:
helm lint examples/task-samples/task-helmchart-sample/task-helmchart-testhelm template task-helmchart-test examples/task-samples/task-helmchart-sample/task-helmchart-testhelm lint examples/function-samples/helmchart-samples/inference-test-sample/inference-testhelm template inference-test examples/function-samples/helmchart-samples/inference-test-sample/inference-testgit diff --checkQA is needed after publishing the corrected chart versions. The BDD coverage
in #1890 verifies that charts without resources fail while the compliant task
and function charts complete successfully.
Issues
Closes #1887
Checklist
Summary by CodeRabbit
New Features
Documentation
Chores