Skip to content

fix(nvca): stop logging ReVal request credentials #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balajinvda merged 5 commits into from
Jul 21, 2026
Merged

fix(nvca): stop logging ReVal request credentials #229

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e22cc36
fix(nvca): stop logging ReVal request credentials
mesutoezdil Jul 17, 2026
c0a9689
fix(nvca): redact HelmChartURL in ReVal payload log, add tests
mesutoezdil Jul 17, 2026
22dee04
Merge remote-tracking branch 'origin/main' into mesutoezdil/fix/nvca-…
mesutoezdil Jul 17, 2026
4eb7d19
test(nvca): cover ImageRegistryAuthConfig in ReVal payload redaction …
mesutoezdil Jul 17, 2026
4728ab6
Merge branch 'main' into mesutoezdil/fix/nvca-reval-credential-logging
balajinvda Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/compute-plane-services/nvca/internal/miniservice/reval_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,15 @@ func (c *revalClient) Render(ctx context.Context, input HelmReValRenderInput) (H
)

log.V(1).Info("Do ReVal request")
log.V(2).WithValues("input", input).Info("Payload")
// input.APIKey, input.HelmRegistryAuthConfig, and input.ImageRegistryAuthConfig
// carry credentials and must not be logged.
log.V(2).WithValues(
"helmChart", input.HelmChartURL,
"releaseName", input.ReleaseName,
"instanceType", input.InstanceType,
"gpu", input.GPUName,
"k8sVersion", input.K8sVersion,
).Info("Payload")
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment thread
mesutoezdil marked this conversation as resolved.

// httpCode tracks the label value for the metric. It defaults to "error" (network failure),
// is set to stage-specific values on pre-call failures, and to the HTTP status code on success.
Expand All @@ -111,6 +119,7 @@ func (c *revalClient) Render(ctx context.Context, input HelmReValRenderInput) (H
return HelmReValRenderOutput{}, err
}

//nolint:gosec // input.APIKey belongs in this request body, sent to the ReVal service itself
payload, err := json.Marshal(input)
if err != nil {
httpCode = "marshal_error"
Expand Down
Loading