Skip to content

fix(worker): remove dead break in nats consumer select #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kristinapathak merged 3 commits into from
Jul 23, 2026
Merged

fix(worker): remove dead break in nats consumer select #361

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a7356a
fix(worker): remove dead break in nats consumer select
mesutoezdil Jul 22, 2026
157a606
Merge branch 'main' into mesutoezdil/fix/nats-consumer-ineffective-break
mesutoezdil Jul 23, 2026
4f2bb7d
Merge branch 'main' into mesutoezdil/fix/nats-consumer-ineffective-break
vrv3814 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/libraries/go/worker/consumer/nats_consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ func fetchMax(ctx context.Context, consumer jetstream.Consumer, maxReq int64) (<
var msg jetstream.Msg
select {
case msg = <-activeFetch.Messages():
break
case <-ctx.Done():
// sure wish we could cancel fetches. best we can do is nack.
// TODO https://github.com/nats-io/nats.go/issues/1651
Expand All @@ -369,7 +368,6 @@ func fetchMax(ctx context.Context, consumer jetstream.Consumer, maxReq int64) (<
zap.L().Debug("message fetched", zap.String("consumer", consumer.CachedInfo().Name))
select {
case retChan <- msg:
break
case <-ctx.Done():
zap.L().Debug("nacking message due to closed context", zap.String("subject", msg.Subject()))
_ = msg.Nak()
Expand Down
Loading