Only allow host-relative LDConfig paths #690
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
ignore-ldconfig-option
branch
2 times, most recently
from
24ede29
to
74d8d64
Compare
cdesiniotis
reviewed
Sep 11, 2024
elezar
force-pushed
the
ignore-ldconfig-option
branch
from
74d8d64
to
994c973
Compare
elezar
force-pushed
the
ignore-ldconfig-option
branch
from
994c973
to
08fb0bc
Compare
cdesiniotis
approved these changes
Sep 16, 2024
tariq1890
approved these changes
Sep 17, 2024
klueska
requested changes
Sep 18, 2024
Signed-off-by: Evan Lezar <[email protected]>
This change removes indirect calls to get the default config from the nvidia-container-runtime-hook. Signed-off-by: Evan Lezar <[email protected]>
This change only allows host-relative LDConfig paths. An allow-ldconfig-from-container feature flag is added to allow for this the default behaviour to be changed. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
ignore-ldconfig-option
branch
from
08fb0bc
to
72a0400
Compare
elezar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only allows host-relative LDConfig paths (i.e. the
nvidia-container-cli.ldconfigsetting starts with an@)An
allow-ldconfig-from-containerfeature flag is added to allow for thisthe default behaviour to be changed.