Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-relnote] switch to the newer qemu artifacts image #887

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

tariq1890
Copy link
Contributor

This PR fixes the recent segfault errors that have been showing up in the CI's multi-arch docker builds lately. This comment summarises the root cause well.

Since our linux runners have picked up the newer kernels, the old qemu versions from the default tonistiigi/binfmt:latest are no longer compatible. Moreover, the latest tag hasn't been updated in over two years. So we switch to the master tag instead which is regularly maintained and is based on qemu 9.2.0 instead

P.S: If you're wondering why the setup-qemu-action doesn't pick up the master tag instead, the maintainers have already responded to that question. See here

So far, this fix has been applied in the gpu-operator and mig-parted repos. They have been working fine with no issue since this fix

NVIDIA/gpu-operator#1248
NVIDIA/mig-parted#167

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of interest, is this a change we could propose to the action repo directly?

@tariq1890
Copy link
Contributor Author

@elezar Yes, I was considering that route and I found that there were multiple requests for the action maintainers to change this default. The maintainer of the github action has explained why that has been pending. See here and here

@tariq1890 tariq1890 merged commit d6c3129 into main Jan 31, 2025
10 checks passed
@tariq1890 tariq1890 deleted the latest-qemu branch January 31, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants