[DRAFT-DO NOT REVIEW] Restructure diffusion subpackage #1268
+12,003
−28,593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Add FIGConvNet to crash example (NVIDIA#1207) * Add FIGConvNet to crash example. * Add FIGConvNet to crash example * Update model config * propose fix some typos (NVIDIA#1209) Signed-off-by: John E <[email protected]> Co-authored-by: Corey adams <[email protected]> * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. --------- Signed-off-by: John E <[email protected]> Co-authored-by: Alexey Kamenev <[email protected]> Co-authored-by: John Eismeier <[email protected]>
* unmigrate the insolation utils * Revert test and compat map * Update importlinter
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working
* Update activations path in dlwp tests * Update example paths
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Update crash readme (NVIDIA#1212) * update license headers- second try * update readme * Bump multi-storage-client to v0.33.0 with rust client (NVIDIA#1156) * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Add jaxtyping to requirements.txt for crash sample (NVIDIA#1218) * update license headers- second try * Update requirements.txt * Updating to address some test issues * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. --------- Co-authored-by: Mohammad Amin Nabian <[email protected]> Co-authored-by: Yongming Ding <[email protected]>
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Update crash readme (NVIDIA#1212) * update license headers- second try * update readme * Bump multi-storage-client to v0.33.0 with rust client (NVIDIA#1156) * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Add jaxtyping to requirements.txt for crash sample (NVIDIA#1218) * update license headers- second try * Update requirements.txt * Updating to address some test issues * Replace 'License' link with 'Dev blog' link (NVIDIA#1215) Co-authored-by: Corey adams <[email protected]> * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Validation fu added to examples/structural_mechanics/crash/train.py (NVIDIA#1204) * validation added: works for multi-node job. * rename and rearrange validation function * validate_every_n_epochs, save_ckpt_every_n_epochs added in config * corrected bug (args of model) in inference * args in validation code updated * val path added and args name changed * validation split added -> write_vtp=False * fixed inference bug * bug fix: write_vtp * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. * Add saikrishnanc-nv to github actors (NVIDIA#1225) * Integrate Curator instructions to the Crash example (NVIDIA#1213) * Integrate Curator instructions * Update docs * Formatting changes * Adding code of conduct (NVIDIA#1214) * Adding code of conduct Adopting the code of conduct from the https://www.contributor-covenant.org/ * Update CODE_OF_CONDUCT.MD Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Create .markdownlintignore * Revise README for PhysicsNeMo resources and guidance Updated the 'Getting Started' section and added new resources for learning AI Physics. * Update README.md --------- Co-authored-by: Mohammad Amin Nabian <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Corey adams <[email protected]> * Cleaning up diffusion models. Not quite done yet. * Restore deleted files * Updating more tests. * Further updates to tests. Datapipes almost working. --------- Co-authored-by: Mohammad Amin Nabian <[email protected]> Co-authored-by: Yongming Ding <[email protected]> Co-authored-by: ram-cherukuri <[email protected]> Co-authored-by: Deepak Akhare <[email protected]> Co-authored-by: Sai Krishnan Chandrasekar <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Update crash readme (NVIDIA#1212) * update license headers- second try * update readme * Bump multi-storage-client to v0.33.0 with rust client (NVIDIA#1156) * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Add jaxtyping to requirements.txt for crash sample (NVIDIA#1218) * update license headers- second try * Update requirements.txt * Updating to address some test issues * Replace 'License' link with 'Dev blog' link (NVIDIA#1215) Co-authored-by: Corey adams <[email protected]> * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Validation fu added to examples/structural_mechanics/crash/train.py (NVIDIA#1204) * validation added: works for multi-node job. * rename and rearrange validation function * validate_every_n_epochs, save_ckpt_every_n_epochs added in config * corrected bug (args of model) in inference * args in validation code updated * val path added and args name changed * validation split added -> write_vtp=False * fixed inference bug * bug fix: write_vtp * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. * Add saikrishnanc-nv to github actors (NVIDIA#1225) * Integrate Curator instructions to the Crash example (NVIDIA#1213) * Integrate Curator instructions * Update docs * Formatting changes * Adding code of conduct (NVIDIA#1214) * Adding code of conduct Adopting the code of conduct from the https://www.contributor-covenant.org/ * Update CODE_OF_CONDUCT.MD Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Create .markdownlintignore * Revise README for PhysicsNeMo resources and guidance Updated the 'Getting Started' section and added new resources for learning AI Physics. * Update README.md --------- Co-authored-by: Mohammad Amin Nabian <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Corey adams <[email protected]> * Cleaning up diffusion models. Not quite done yet. * Restore deleted files * Updating more tests. * Fixed minor bug in shape validation in SongUNet (NVIDIA#1230) Signed-off-by: Charlelie Laurent <[email protected]> * Add Zarr reader for Crash (NVIDIA#1228) * Add Zarr reader for Crash * Update README * Update validation logic of point data in Zarr reader Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update examples/structural_mechanics/crash/zarr_reader.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Add a test for 2D feature arrays * Update examples/structural_mechanics/crash/zarr_reader.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Further updates to tests. Datapipes almost working. * update import paths * Starting to clean up dependency tree. --------- Signed-off-by: Charlelie Laurent <[email protected]> Co-authored-by: Mohammad Amin Nabian <[email protected]> Co-authored-by: Yongming Ding <[email protected]> Co-authored-by: ram-cherukuri <[email protected]> Co-authored-by: Deepak Akhare <[email protected]> Co-authored-by: Sai Krishnan Chandrasekar <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Charlelie Laurent <[email protected]>
…for greptile (NVIDIA#1219) * Added initial set of coding standards for model implementations Signed-off-by: Charlelie Laurent <[email protected]> * Fixed typos + review comments + added details Signed-off-by: Charlelie Laurent <[email protected]> * Added more rules for models Signed-off-by: Charlelie Laurent <[email protected]> * Added model rules to PR checklist Signed-off-by: Charlelie Laurent <[email protected]> * Added cusror rules for models Signed-off-by: Charlelie Laurent <[email protected]> * Linked the wiki page to the PR template Signed-off-by: Charlelie Laurent <[email protected]> * Fixed typo in PR checklist Signed-off-by: Charlelie Laurent <[email protected]> --------- Signed-off-by: Charlelie Laurent <[email protected]>
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Update crash readme (NVIDIA#1212) * update license headers- second try * update readme * Bump multi-storage-client to v0.33.0 with rust client (NVIDIA#1156) * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Add jaxtyping to requirements.txt for crash sample (NVIDIA#1218) * update license headers- second try * Update requirements.txt * Updating to address some test issues * Replace 'License' link with 'Dev blog' link (NVIDIA#1215) Co-authored-by: Corey adams <[email protected]> * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Validation fu added to examples/structural_mechanics/crash/train.py (NVIDIA#1204) * validation added: works for multi-node job. * rename and rearrange validation function * validate_every_n_epochs, save_ckpt_every_n_epochs added in config * corrected bug (args of model) in inference * args in validation code updated * val path added and args name changed * validation split added -> write_vtp=False * fixed inference bug * bug fix: write_vtp * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. * Add saikrishnanc-nv to github actors (NVIDIA#1225) * Integrate Curator instructions to the Crash example (NVIDIA#1213) * Integrate Curator instructions * Update docs * Formatting changes * Adding code of conduct (NVIDIA#1214) * Adding code of conduct Adopting the code of conduct from the https://www.contributor-covenant.org/ * Update CODE_OF_CONDUCT.MD Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Create .markdownlintignore * Revise README for PhysicsNeMo resources and guidance Updated the 'Getting Started' section and added new resources for learning AI Physics. * Update README.md --------- Co-authored-by: Mohammad Amin Nabian <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Corey adams <[email protected]> * Cleaning up diffusion models. Not quite done yet. * Restore deleted files * Updating more tests. * Fixed minor bug in shape validation in SongUNet (NVIDIA#1230) Signed-off-by: Charlelie Laurent <[email protected]> * Add Zarr reader for Crash (NVIDIA#1228) * Add Zarr reader for Crash * Update README * Update validation logic of point data in Zarr reader Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update examples/structural_mechanics/crash/zarr_reader.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Add a test for 2D feature arrays * Update examples/structural_mechanics/crash/zarr_reader.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Further updates to tests. Datapipes almost working. * update import paths * Starting to clean up dependency tree. * Add AR RT and OT schemes to Crash FIGConvNet (NVIDIA#1232) * Add AR and OT schemes for FIGConvNet * Add tests * Soothe the linter * Fix the tests * Fixing and adjusting a broad suite of tests. * Update test/domain_parallel/conftest.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Minor fix --------- Signed-off-by: Charlelie Laurent <[email protected]> Co-authored-by: Mohammad Amin Nabian <[email protected]> Co-authored-by: Yongming Ding <[email protected]> Co-authored-by: ram-cherukuri <[email protected]> Co-authored-by: Deepak Akhare <[email protected]> Co-authored-by: Sai Krishnan Chandrasekar <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Charlelie Laurent <[email protected]> Co-authored-by: Alexey Kamenev <[email protected]>
* Breakdown of rules into smaller rules Signed-off-by: Charlelie Laurent <[email protected]> * Fix mismatches in rule IDs referenced in rule text Signed-off-by: Charlelie Laurent <[email protected]> --------- Signed-off-by: Charlelie Laurent <[email protected]>
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Updating to address some test issues * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. * Cleaning up diffusion models. Not quite done yet. * Restore deleted files * Updating more tests. * Further updates to tests. Datapipes almost working. * update import paths * Starting to clean up dependency tree. * Fixing and adjusting a broad suite of tests. * Update test/domain_parallel/conftest.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Minor fix * Not seeing any errors in testing ... * Formatting active learning module docstrings (NVIDIA#1238) * docs: fixing Protocol class reference formatting Signed-off-by: Kelvin Lee <[email protected]> * docs: removing mermaid diagram from protocols Signed-off-by: Kelvin Lee <[email protected]> * docs: adding active learning index * docs: revising docstrings for sphinx formatting * docs: fix placeholder URL for active learning main docs --------- Signed-off-by: Kelvin Lee <[email protected]> --------- Signed-off-by: Kelvin Lee <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Kelvin Lee <[email protected]>
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Updating to address some test issues * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. * Cleaning up diffusion models. Not quite done yet. * Restore deleted files * Updating more tests. * Further updates to tests. Datapipes almost working. * update import paths * Starting to clean up dependency tree. * Fixing and adjusting a broad suite of tests. * Update test/domain_parallel/conftest.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Minor fix * Not seeing any errors in testing ... * A new X-MeshGraphNet example for reservoir simulation. (NVIDIA#1186) * X-MGN for reservoir simulation Signed-off-by: Tsubasa Onishi <[email protected]> * installation bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * well object docstring fix Signed-off-by: Tsubasa Onishi <[email protected]> * more well object docstring fix Signed-off-by: Tsubasa Onishi <[email protected]> * improve path_utils Signed-off-by: Tsubasa Onishi <[email protected]> * fix while space in config Signed-off-by: Tsubasa Onishi <[email protected]> * fix version inconsistency in requirement.txt Signed-off-by: Tsubasa Onishi <[email protected]> * add versions for some libs in requirement.txt Signed-off-by: Tsubasa Onishi <[email protected]> * improve exception handling in mldlow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve mldlow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve datetiem in mlflow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve exception handling in inference Signed-off-by: Tsubasa Onishi <[email protected]> * improve inference Signed-off-by: Tsubasa Onishi <[email protected]> * improve ecl_reader Signed-off-by: Tsubasa Onishi <[email protected]> * formatting Signed-off-by: Tsubasa Onishi <[email protected]> * improve preprocessor Signed-off-by: Tsubasa Onishi <[email protected]> * improve preprocessor loop Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * grad accum bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * total loss bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * added some safe guard for connection indexing Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * update ecl_reader Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup utils Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup * cleanup * update configs * Update README.md style guide rule changes * Update README.md * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve docstring fmt Signed-off-by: Tsubasa Onishi <[email protected]> * update license yr Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup well Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup preproc fmt Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup preproc fmt Signed-off-by: Tsubasa Onishi <[email protected]> * cimprove infrence fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve datetime Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * improve train.py fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve requirement Signed-off-by: Tsubasa Onishi <[email protected]> * ilcense header Signed-off-by: Tsubasa Onishi <[email protected]> * improve ecl reader logging Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup Signed-off-by: Tsubasa Onishi <[email protected]> * license header Signed-off-by: Tsubasa Onishi <[email protected]> * improve graph builder (parallel) + added results to readme Signed-off-by: Tsubasa Onishi <[email protected]> * delete some unsed files Signed-off-by: Tsubasa Onishi <[email protected]> * address PR comments Signed-off-by: Tsubasa Onishi <[email protected]> * improve inference grdecl header Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * support time series Signed-off-by: Tsubasa Onishi <[email protected]> * update config Signed-off-by: Tsubasa Onishi <[email protected]> * minor update Signed-off-by: Tsubasa Onishi <[email protected]> * improve graph builder Signed-off-by: Tsubasa Onishi <[email protected]> * update ecl_reader logging Signed-off-by: Tsubasa Onishi <[email protected]> * replace pickle with json Signed-off-by: Tsubasa Onishi <[email protected]> * add license headers Signed-off-by: Tsubasa Onishi <[email protected]> * remove unused png files Signed-off-by: Tsubasa Onishi <[email protected]> * remove unsed import Signed-off-by: Tsubasa Onishi <[email protected]> * remove emojis Signed-off-by: Tsubasa Onishi <[email protected]> * replace print with logger Signed-off-by: Tsubasa Onishi <[email protected]> * update docstring Signed-off-by: Tsubasa Onishi <[email protected]> * update readme Signed-off-by: Tsubasa Onishi <[email protected]> * minor updates Signed-off-by: Tsubasa Onishi <[email protected]> * update readme Signed-off-by: Tsubasa Onishi <[email protected]> * update header Signed-off-by: Tsubasa Onishi <[email protected]> --------- Signed-off-by: Tsubasa Onishi <[email protected]> Co-authored-by: megnvidia <[email protected]> * Add knn to autodoc table. (NVIDIA#1244) --------- Signed-off-by: Tsubasa Onishi <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: tonishi-nv <[email protected]> Co-authored-by: megnvidia <[email protected]>
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Updating to address some test issues * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. * Cleaning up diffusion models. Not quite done yet. * Restore deleted files * Updating more tests. * Further updates to tests. Datapipes almost working. * update import paths * Starting to clean up dependency tree. * Fixing and adjusting a broad suite of tests. * Update test/domain_parallel/conftest.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Minor fix * Not seeing any errors in testing ... * A new X-MeshGraphNet example for reservoir simulation. (NVIDIA#1186) * X-MGN for reservoir simulation Signed-off-by: Tsubasa Onishi <[email protected]> * installation bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * well object docstring fix Signed-off-by: Tsubasa Onishi <[email protected]> * more well object docstring fix Signed-off-by: Tsubasa Onishi <[email protected]> * improve path_utils Signed-off-by: Tsubasa Onishi <[email protected]> * fix while space in config Signed-off-by: Tsubasa Onishi <[email protected]> * fix version inconsistency in requirement.txt Signed-off-by: Tsubasa Onishi <[email protected]> * add versions for some libs in requirement.txt Signed-off-by: Tsubasa Onishi <[email protected]> * improve exception handling in mldlow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve mldlow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve datetiem in mlflow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve exception handling in inference Signed-off-by: Tsubasa Onishi <[email protected]> * improve inference Signed-off-by: Tsubasa Onishi <[email protected]> * improve ecl_reader Signed-off-by: Tsubasa Onishi <[email protected]> * formatting Signed-off-by: Tsubasa Onishi <[email protected]> * improve preprocessor Signed-off-by: Tsubasa Onishi <[email protected]> * improve preprocessor loop Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * grad accum bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * total loss bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * added some safe guard for connection indexing Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * update ecl_reader Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup utils Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup * cleanup * update configs * Update README.md style guide rule changes * Update README.md * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve docstring fmt Signed-off-by: Tsubasa Onishi <[email protected]> * update license yr Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup well Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup preproc fmt Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup preproc fmt Signed-off-by: Tsubasa Onishi <[email protected]> * cimprove infrence fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve datetime Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * improve train.py fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve requirement Signed-off-by: Tsubasa Onishi <[email protected]> * ilcense header Signed-off-by: Tsubasa Onishi <[email protected]> * improve ecl reader logging Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup Signed-off-by: Tsubasa Onishi <[email protected]> * license header Signed-off-by: Tsubasa Onishi <[email protected]> * improve graph builder (parallel) + added results to readme Signed-off-by: Tsubasa Onishi <[email protected]> * delete some unsed files Signed-off-by: Tsubasa Onishi <[email protected]> * address PR comments Signed-off-by: Tsubasa Onishi <[email protected]> * improve inference grdecl header Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * support time series Signed-off-by: Tsubasa Onishi <[email protected]> * update config Signed-off-by: Tsubasa Onishi <[email protected]> * minor update Signed-off-by: Tsubasa Onishi <[email protected]> * improve graph builder Signed-off-by: Tsubasa Onishi <[email protected]> * update ecl_reader logging Signed-off-by: Tsubasa Onishi <[email protected]> * replace pickle with json Signed-off-by: Tsubasa Onishi <[email protected]> * add license headers Signed-off-by: Tsubasa Onishi <[email protected]> * remove unused png files Signed-off-by: Tsubasa Onishi <[email protected]> * remove unsed import Signed-off-by: Tsubasa Onishi <[email protected]> * remove emojis Signed-off-by: Tsubasa Onishi <[email protected]> * replace print with logger Signed-off-by: Tsubasa Onishi <[email protected]> * update docstring Signed-off-by: Tsubasa Onishi <[email protected]> * update readme Signed-off-by: Tsubasa Onishi <[email protected]> * minor updates Signed-off-by: Tsubasa Onishi <[email protected]> * update readme Signed-off-by: Tsubasa Onishi <[email protected]> * update header Signed-off-by: Tsubasa Onishi <[email protected]> --------- Signed-off-by: Tsubasa Onishi <[email protected]> Co-authored-by: megnvidia <[email protected]> * Add knn to autodoc table. (NVIDIA#1244) * Enable import linting on internal imports. * Remove ensure_available function, it's confusing * Add logging imports to utils, and fix imports in examples. * Update imports in minimal examples * Update structural mechanics examples * Update import paths: reservoir_sim * Update import paths: additive manufacturing * Update import paths: topodiff * Update import paths: weather part 1 * Update import paths: weather part 2 * Update import paths: molecular dynamics * Update import paths: geophysics * Update import paths: cfd + external_aero 1 * Update import paths: cfd + external_aero 2 * Remove more DGL examples * Remove more DGL examples * cfd examples 3 * Last batch of example import fixes! * Enforce and protect external deps in utils. * Remove DGL. :party: * Don't force models yet --------- Signed-off-by: Tsubasa Onishi <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: tonishi-nv <[email protected]> Co-authored-by: megnvidia <[email protected]>
* Deleted RegistreableModule Signed-off-by: Charlelie Laurent <[email protected]> * Removed 'PhysicsNeMo' suffix in Module.from_torch method Signed-off-by: Charlelie Laurent <[email protected]> * Implemented automatic registration for Module subclasses Signed-off-by: Charlelie Laurent <[email protected]> * Fixed unused name Signed-off-by: Charlelie Laurent <[email protected]> --------- Signed-off-by: Charlelie Laurent <[email protected]>
* Initiated deprecation of field 'name' in ModelMetaData Signed-off-by: Charlelie Laurent <[email protected]> * Removed all occurences of 'name' field in ModelMetaData Signed-off-by: Charlelie Laurent <[email protected]> --------- Signed-off-by: Charlelie Laurent <[email protected]>
* Move filesystems and version_check to core * Fix version check tests * Reorganize distributed, domain_parallel, and begin nn / utils cleanup. * Move modules and meta to core. Move registry to core. No tests fixed yet. * Add missing init files * Update build system and specify some deps. * Reorganize tests. * Update init files * Clean up neighbor tools. * Update testing * Fix compat tests * Move core model tests to tests/core/ * Add import lint config * Relocate layers * Move graphcast utils into model directory * Relocating util functionalities. * Further clean up and organize tests. * utils tests are passing now * Cleaning up distributed tests * Patching tests working again in nn * Fix sdf test * Fix zenith angle tests * Some organization of tests. Checkpoints is moved into utils. * Remove launch.utils and launch.config. Checkpointing is moved to phsyicsnemo.utils, launch.config is just gone. It was empty. * Most nn tests are passing * Further cleanup. Getting there! * Remove constants file * Add import linting to pre-commit. * Move gnn layers and start to fix several model tests. * AFNO is now passing. * Rnn models passing. * Fix improt * Healpix tests are working * Domino and unet working * Updating to address some test issues * MGN tests passing again * Most graphcast tests passing again * Move nd conv layers. * update fengwu and pangu * Update sfno and pix2pix test * update tests for figconvnet, swinrnn, superresnet * updating more models to pass * Update distributed tests, now passing. * Domain parallel tests now passing. * Fix active learning imports so tests pass in refactor * Fix some metric imports * Remove deploy package * Remove unused test file * unmigrate these files ... again? * Update import linter. * Cleaning up diffusion models. Not quite done yet. * Restore deleted files * Updating more tests. * Further updates to tests. Datapipes almost working. * update import paths * Starting to clean up dependency tree. * Fixing and adjusting a broad suite of tests. * Update test/domain_parallel/conftest.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Minor fix * Not seeing any errors in testing ... * A new X-MeshGraphNet example for reservoir simulation. (NVIDIA#1186) * X-MGN for reservoir simulation Signed-off-by: Tsubasa Onishi <[email protected]> * installation bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * well object docstring fix Signed-off-by: Tsubasa Onishi <[email protected]> * more well object docstring fix Signed-off-by: Tsubasa Onishi <[email protected]> * improve path_utils Signed-off-by: Tsubasa Onishi <[email protected]> * fix while space in config Signed-off-by: Tsubasa Onishi <[email protected]> * fix version inconsistency in requirement.txt Signed-off-by: Tsubasa Onishi <[email protected]> * add versions for some libs in requirement.txt Signed-off-by: Tsubasa Onishi <[email protected]> * improve exception handling in mldlow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve mldlow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve datetiem in mlflow_utils Signed-off-by: Tsubasa Onishi <[email protected]> * improve exception handling in inference Signed-off-by: Tsubasa Onishi <[email protected]> * improve inference Signed-off-by: Tsubasa Onishi <[email protected]> * improve ecl_reader Signed-off-by: Tsubasa Onishi <[email protected]> * formatting Signed-off-by: Tsubasa Onishi <[email protected]> * improve preprocessor Signed-off-by: Tsubasa Onishi <[email protected]> * improve preprocessor loop Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * grad accum bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * total loss bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * added some safe guard for connection indexing Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * bug fix Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup Signed-off-by: Tsubasa Onishi <[email protected]> * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * update ecl_reader Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup utils Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup * cleanup * update configs * Update README.md style guide rule changes * Update README.md * fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve docstring fmt Signed-off-by: Tsubasa Onishi <[email protected]> * update license yr Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup well Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup preproc fmt Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup preproc fmt Signed-off-by: Tsubasa Onishi <[email protected]> * cimprove infrence fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve datetime Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * improve train.py fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme fmt Signed-off-by: Tsubasa Onishi <[email protected]> * improve requirement Signed-off-by: Tsubasa Onishi <[email protected]> * ilcense header Signed-off-by: Tsubasa Onishi <[email protected]> * improve ecl reader logging Signed-off-by: Tsubasa Onishi <[email protected]> * cleanup Signed-off-by: Tsubasa Onishi <[email protected]> * license header Signed-off-by: Tsubasa Onishi <[email protected]> * improve graph builder (parallel) + added results to readme Signed-off-by: Tsubasa Onishi <[email protected]> * delete some unsed files Signed-off-by: Tsubasa Onishi <[email protected]> * address PR comments Signed-off-by: Tsubasa Onishi <[email protected]> * improve inference grdecl header Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * improve readme Signed-off-by: Tsubasa Onishi <[email protected]> * support time series Signed-off-by: Tsubasa Onishi <[email protected]> * update config Signed-off-by: Tsubasa Onishi <[email protected]> * minor update Signed-off-by: Tsubasa Onishi <[email protected]> * improve graph builder Signed-off-by: Tsubasa Onishi <[email protected]> * update ecl_reader logging Signed-off-by: Tsubasa Onishi <[email protected]> * replace pickle with json Signed-off-by: Tsubasa Onishi <[email protected]> * add license headers Signed-off-by: Tsubasa Onishi <[email protected]> * remove unused png files Signed-off-by: Tsubasa Onishi <[email protected]> * remove unsed import Signed-off-by: Tsubasa Onishi <[email protected]> * remove emojis Signed-off-by: Tsubasa Onishi <[email protected]> * replace print with logger Signed-off-by: Tsubasa Onishi <[email protected]> * update docstring Signed-off-by: Tsubasa Onishi <[email protected]> * update readme Signed-off-by: Tsubasa Onishi <[email protected]> * minor updates Signed-off-by: Tsubasa Onishi <[email protected]> * update readme Signed-off-by: Tsubasa Onishi <[email protected]> * update header Signed-off-by: Tsubasa Onishi <[email protected]> --------- Signed-off-by: Tsubasa Onishi <[email protected]> Co-authored-by: megnvidia <[email protected]> * Add knn to autodoc table. (NVIDIA#1244) * Enable import linting on internal imports. * Remove ensure_available function, it's confusing * Add logging imports to utils, and fix imports in examples. * Update imports in minimal examples * Update structural mechanics examples * Update import paths: reservoir_sim * Update import paths: additive manufacturing * Update import paths: topodiff * Update import paths: weather part 1 * Update import paths: weather part 2 * Update import paths: molecular dynamics * Update import paths: geophysics * Update import paths: cfd + external_aero 1 * Update import paths: cfd + external_aero 2 * Remove more DGL examples * Remove more DGL examples * cfd examples 3 * Last batch of example import fixes! * Enforce and protect external deps in utils. * Remove DGL. :party: * Don't force models yet * Update version (NVIDIA#1193) * Fix depenedncies to enable hello world (NVIDIA#1195) * Remove zero-len arrays from test dataset (NVIDIA#1198) * Merge updates to Gray Scott example (NVIDIA#1239) * Remove pyevtk * update dependency * update dimensions * ci issues * Interpolation model example (NVIDIA#1149) * Temporal interpolation training recipe * Add README * Docs changes based on comments * Update docstrings and README * Add temporal interpolation animation * Add animation link * Add shape check in loss * Updates of configs + trainer * Update config comments * Update README.md style guide edits * Added wandb logging Signed-off-by: Charlelie Laurent <[email protected]> * Reformated sections in docstring for GeometricL2Loss Signed-off-by: Charlelie Laurent <[email protected]> * Update README and configs * README changes + type hint fixes * Update README.md * Draft of validation script * Update validation and README * Fixed command in README.md for temporal_interpolation example Signed-off-by: Charlelie Laurent <[email protected]> * Removed unused import in datapipe/climate_interp.py Signed-off-by: Charlelie Laurent <[email protected]> * Updated license headers in temporal_interpolation example Signed-off-by: Charlelie Laurent <[email protected]> * Renamed methods to avoid implicit shadowing in Trainer class Signed-off-by: Charlelie Laurent <[email protected]> * Cosmetic changes in train.py and removed unused import in validate.py Signed-off-by: Charlelie Laurent <[email protected]> * Added clamp in validate.py to make sure step does not go out of bounds Signed-off-by: Charlelie Laurent <[email protected]> * Added the temporal_interpolation example to the docs + updated CHANGELOG.md Signed-off-by: Charlelie Laurent <[email protected]> * Addressing remaining comments * Merged two data source classes in climate_interp.py Signed-off-by: Charlelie Laurent <[email protected]> --------- Signed-off-by: Charlelie Laurent <[email protected]> Co-authored-by: Charlelie Laurent <[email protected]> Co-authored-by: megnvidia <[email protected]> Co-authored-by: Charlelie Laurent <[email protected]> * update versions --------- Signed-off-by: Tsubasa Onishi <[email protected]> Signed-off-by: Charlelie Laurent <[email protected]> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: tonishi-nv <[email protected]> Co-authored-by: megnvidia <[email protected]> Co-authored-by: Kaustubh Tangsali <[email protected]> Co-authored-by: Jussi Leinonen <[email protected]> Co-authored-by: Charlelie Laurent <[email protected]> Co-authored-by: Charlelie Laurent <[email protected]> Co-authored-by: Kaustubh Tangsali <[email protected]>
Signed-off-by: Charlelie Laurent <[email protected]>
Signed-off-by: Charlelie Laurent <[email protected]>
CharlelieLrt
requested review from
Alexey-Kamenev,
RishikeshRanade,
coreyjadams,
dallasfoster,
ktangsali,
mnabian and
peterdsharpe
as code owners
CharlelieLrt
requested review from
NickGeneva,
loliverhennigh,
megnvidia and
pzharrington
as code owners
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
CharlelieLrt
added
5 - DO NOT MERGE
CharlelieLrt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.