-
Notifications
You must be signed in to change notification settings - Fork 512
Install ci #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.0-refactor
Are you sure you want to change the base?
Install ci #1274
Conversation
Greptile OverviewGreptile SummaryThis PR adds CI infrastructure to test package installation via both pip and uv across Python 3.11-3.13 and drops support for Python 3.10. The changes also improve MacOS compatibility by conditionally enabling pin_memory based on CUDA availability. Key Changes:
Issues Found:
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (3)
-
.github/workflows/install-ci.yml, line 33 (link)logic:
--groupflag requires pip >= 25.1, but older versions may be installed by default on runners -
README.md, line 10 (link)logic: Badge URL points to
coreyjadams/physicsnemo(author's fork), should point tonvidia/physicsnemo -
.github/workflows/install-ci.yml, line 63 (link)style:
UV_PREVIEWis deprecated -uv syncnatively supports--groupwithout preview mode
6 files reviewed, 3 comments
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.