Skip to content

Conversation

@coreyjadams
Copy link
Collaborator

PhysicsNeMo Pull Request

Ensure install-ci and precommit are included in the merge queue.

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile Summary

This PR configures GitHub Actions workflows to run on merge queue events, ensuring that install-ci and precommit checks execute before PRs are merged through the merge queue.

Changes:

  • .github/workflows/install-ci.yml: Added merge_group trigger and updated the test matrix conditionals to treat merge queue events the same as PR/push events (running only on ubuntu-latest with Python 3.12 for efficiency)
  • .github/workflows/pre-commit.yml: Added merge_group trigger to run pre-commit hooks on merge queue events

Assessment:
The changes are minimal, well-scoped, and follow best practices for GitHub merge queue configuration. The matrix conditional logic correctly groups merge_group with pull_request and push events to maintain efficient CI execution while ensuring adequate testing before merge.

Important Files Changed

Filename Overview
.github/workflows/install-ci.yml Added merge_group trigger and updated matrix conditionals to include merge queue events alongside PR/push events for efficient CI execution
.github/workflows/pre-commit.yml Added merge_group trigger to run pre-commit checks on merge queue events, ensuring code quality before merging

@ktangsali ktangsali self-requested a review January 6, 2026 22:23
@ktangsali ktangsali merged commit 0a3d467 into NVIDIA:main Jan 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants