Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Corrdiff optimizations for drastic increase of training efficiency #809

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

LostnEkko
Copy link
Contributor

@LostnEkko LostnEkko commented Mar 14, 2025

Various Corrdiff optimizations for drastic increase of training efficiency

Description

  • Updated CorrDiff training code to support multiple patch iterations
    to amortize regression cost and usage of torch.compile
  • Refactored modulus/models/diffusion/layers.py to optimize data type casting workflow,
    avoiding unnecessary casting under autocast mode
  • Refactored Conv2d to enable fusion of conv2d with bias addition
  • Refactored GroupNorm, UNetBlock, SongUNet, SongUNetPosEmbd to support usage of
    Apex GroupNorm, fusion of activation with GroupNorm, and AMP workflow.
  • Updated SongUNetPosEmbd to avoid unnecessary HtoD Memcpy of pos_embd
  • Updated from_checkpoint to accommodate usage of Apex GroupNorm
  • Refactored CorrDiff NVTX annotation workflow to be configurable

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@CharlelieLrt CharlelieLrt self-requested a review March 14, 2025 18:07
@CharlelieLrt CharlelieLrt added enhancement New feature or request 3 - Ready for Review Ready for review by team 5 - Merge After Dependencies Depends on another PR: do not merge out of order Earth-2 labels Mar 14, 2025
@mnabian
Copy link
Collaborator

mnabian commented Mar 14, 2025

/blossom-ci

@CharlelieLrt CharlelieLrt mentioned this pull request Mar 18, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 5 - Merge After Dependencies Depends on another PR: do not merge out of order Earth-2 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants