Fix row conversion test #1577
Merged
Fix row conversion test #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
|
build |
1 similar comment
|
build |
|
re-trigger to get a faster node for premerge. the previous one has a super slow CPU for compiling |
|
build |
|
Sure. Please go ahead. |
This was referenced Nov 21, 2023
|
@ttnghia can you add a description of the workaround to the PR |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround to fix #1567.
Instead of passing transform iterators into
thrust::inclusive_scan, we evaluate the input values and pass in the pointers instead. This helps fixing the (mysterious) memory issue reported in #1567. We still don't know what causes it and still need to investigate further.