Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .clang-format style and update docs [skip ci] #1587

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Nov 21, 2023

Since we are using cudf's C++ style for pre-commit hook, we should rely on it entirely. This PR removes our customized version of .clang-format style and updates our documentation to explicitly instruct how to format code.

Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 21, 2023
@ttnghia ttnghia self-assigned this Nov 21, 2023
@ttnghia ttnghia changed the title Remove .clang-format style and update docs Remove .clang-format style and update docs [skip ci] Nov 21, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia requested a review from jlowe November 21, 2023 23:26
@ttnghia
Copy link
Collaborator Author

ttnghia commented Nov 22, 2023

build

@ttnghia ttnghia merged commit 6b32916 into NVIDIA:branch-23.12 Nov 22, 2023
2 checks passed
@ttnghia ttnghia deleted the remove_clangformat_style branch June 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants