Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parse_uri to limit query with a column #1719

Merged

Conversation

hyperbolic2346
Copy link
Collaborator

This PR adds support for a column to select the parameter for each row in a URI.

Branched off of #1704 and is draft until that PR is merged.

Closes #1718

@hyperbolic2346 hyperbolic2346 self-assigned this Jan 23, 2024
@hyperbolic2346 hyperbolic2346 marked this pull request as ready for review January 24, 2024 22:27
@hyperbolic2346
Copy link
Collaborator Author

build

Copy link
Collaborator

@nvdbaranec nvdbaranec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ LGTM

@mythrocks
Copy link
Collaborator

Just reviewed the Java bit. LGTM.

Thank you, @hyperbolic2346.

@hyperbolic2346 hyperbolic2346 merged commit 1d27b33 into NVIDIA:branch-24.02 Jan 24, 2024
3 checks passed
@hyperbolic2346 hyperbolic2346 deleted the mwilson/parse_uri_query_column branch January 24, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support returning query portions that match corresponding rows in another column.
3 participants