-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parse_uri
to limit query with a column
#1719
Merged
hyperbolic2346
merged 13 commits into
NVIDIA:branch-24.02
from
hyperbolic2346:mwilson/parse_uri_query_column
Jan 24, 2024
Merged
Add support for parse_uri
to limit query with a column
#1719
hyperbolic2346
merged 13 commits into
NVIDIA:branch-24.02
from
hyperbolic2346:mwilson/parse_uri_query_column
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Wilson <[email protected]>
Signed-off-by: Mike Wilson <[email protected]>
Signed-off-by: Mike Wilson <[email protected]>
Signed-off-by: Mike Wilson <[email protected]>
Signed-off-by: Mike Wilson <[email protected]>
…se_uri_query_literal
Co-authored-by: nvdbaranec <[email protected]>
Signed-off-by: Mike Wilson <[email protected]>
… column. Signed-off-by: Mike Wilson <[email protected]>
…se_uri_query_column
Signed-off-by: Mike Wilson <[email protected]>
Signed-off-by: Mike Wilson <[email protected]>
build |
nvdbaranec
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ LGTM
mythrocks
approved these changes
Jan 24, 2024
Just reviewed the Java bit. LGTM. Thank you, @hyperbolic2346. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a column to select the parameter for each row in a URI.
Branched off of #1704 and is draft until that PR is merged.
Closes #1718