Fix dynamic pruning regression in GpuFileSourceScanExec #11191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
build |
abellina
approved these changes
Jul 15, 2024
|
I see this change improves our time by ~100s, so we are in the right direction. There is another regression, likely in this repo, but I think it's separate for now (reverting the original change you made still has us ~30 seconds slower than before). Merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11189. The change in #11170 removed the
selectedPartitionsparameter but forgot to update the occurrences in the method to usedynamicallySelectedPartitionswhich is what was actually passed to the method. This effectively caused dynamic partition filters to not be applied.