Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompoundConfig ctors incompatible with invoking Accelergy as subcommand #296

Open
gilbertmike opened this issue Dec 20, 2024 · 1 comment

Comments

@gilbertmike
Copy link
Collaborator

Only one of three CompoundConfig ctors populate the inFiles member. However, the inFiles member is used as an argument to invoke Accelergy as a subcommand. The CompoundConfig ctor that does not load from a file is specifically incompatible with this method for invoking Accelergy.

Currently, my solution is to have PyTimeloop call Accelergy and ensure that the config passed to Timeloop already includes ERT and ART keys.

I think perhaps calling Accelergy should be handled not in the model app (or, at least not in the constructor), but in main since file input is specific to using the Timeloop binary.

@angshuman-parashar
Copy link
Collaborator

I think it's ok to remove Accelergy calls from the C++ application. Accelergy calls can be in PyTimeloop. The C++ application either takes in an ERT or uses the legacy PAT model interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants