Spike: Layout/breadcrumbs in Pages router #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
reviewed
May 21, 2024
src/pages/collections/[id].tsx
Outdated
| ); | ||
| }; | ||
|
|
||
| // Imagine an API call somewhere in here |
There was a problem hiding this comment.
Have you tried passing this mocked API-fetched data to the component? How would this change if you use this breadcrumbs array as a prop in Collection, i.e. const Collection = ({ breadcrumbs }) => {.....
You could use the last object in the array as the value that is passed to setBreadcrumbs.
There was a problem hiding this comment.
Right, sorry for the confusion of trying to represent two approaches within the same file but yes imagining that as a prop to Collections. If that's the case though, I wouldn't use the context at all
7emansell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
Investigates DR-2966.
This PR does the following:
Layoutcomponent that contains header, DS provider, feedback, etcLayoutto all pages/divisions/[slug],/collections/[slug],/divisions,/collectionsHow has this been tested?
Accessibility concerns or updates
Checklist: