Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2141: Delete Duplicate Work Identifiers #356

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

mitri-slory
Copy link
Contributor

@mitri-slory mitri-slory commented Sep 5, 2024

This PR focuses on finding a way to prevent duplicate work_identifier rows from being created which caused issues when clustering some works. The idea here is to first delete the current work_identifier duplicates from the QA and prod environment. Then, add a unique constraint to both the work_id and identifier_id columns through a migration.

Copy link
Contributor

@kylevillegas93 kylevillegas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good! Nice work. I need some more time to digest and I will take this across the finish line next week.

@mitri-slory mitri-slory merged commit 2beac30 into main Oct 9, 2024
1 check passed
@mitri-slory mitri-slory deleted the SFR-2141_DeleteDuplicateWorkIdentifers branch October 9, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants