Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2052: Replace OCLC Worldcat API v1 calls with v2 calls #382

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

Apophenia
Copy link
Contributor

@Apophenia Apophenia commented Sep 30, 2024

  • Creates an additional function to retrieve metadata token
  • Uses that token to make calls to OCLC catalog

Discrepancies that may be related to new xml endpoint:

  • "Subject" mapping sometimes contains "OCoLC" prefixes and other identifiers(?) that don't look standard
  • "Is part of" field we have mapped as default doesn't seem to show up much (since we discovered it's deprecated this isn't that surprising?) but sometimes seeing a trailing semicolon in Met publications, unclear if error in data or mapping
  • extra spaces before lssn in identifiers, unclear if error in data or mapping

The subject mapping is probably the most severe issue I can see when spot-checking entries.

Some of the repeated token request functionality could probably be abstracted into a utility function, but my priority was being able to run the process and check that the data looks equivalent (not yet sure it does!)

@Apophenia Apophenia marked this pull request as ready for review September 30, 2024 20:59
@Apophenia Apophenia merged commit 1192f48 into main Oct 1, 2024
1 check passed
@Apophenia Apophenia deleted the SFR-2052 branch October 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants