Skip to content

feat(ecs): allow component params to be enum #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tchips46 merged 4 commits into from
Apr 14, 2026
+8 −9
Merged

feat(ecs): allow component params to be enum #291

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06e70f7
feat(ecs): allow component params to be enum
Tchips46 Apr 14, 2026
af77aa8
fix(lib-ecs): not builded type required
Tchips46 Apr 14, 2026
0862193
fix(lib-ecs): review
Tchips46 Apr 14, 2026
1799e1a
fix(lib-ecs): review
Tchips46 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ecs-lib/lib/libecs.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface ClassHandle {
[Symbol.dispose](): void;
clone(): this;
}
export interface container extends ClassHandle {
export interface container extends ClassHandle, Iterable<any | undefined> {
size(): number;
get(_0: number): any | undefined | undefined;
push_back(_0?: any): void;
Expand Down
2 changes: 1 addition & 1 deletion packages/ecs-lib/src/editor-manifest.type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ type ECSStringElement = {
/**
* Values allowed for the element
*/
enum?: string[];
enum?: string[] | Record<string, any>;
} & ECSElementDefaults<"string", string>;

/**
Expand Down
1 change: 1 addition & 0 deletions packages/ecs-lib/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export { AbstractECSLibrary } from "./ecs-library.abstract";
// @ts-ignore
Comment thread
Exeloo marked this conversation as resolved.
Outdated
export type { Component, System, Registry, SparseArray, Entity } from "../lib/libecs";
export type * from "./editor-manifest.type";
10 changes: 3 additions & 7 deletions packages/ecs-lib/test/Registry.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ class Position {
) {}
}

const getRunSystemsParams = (registry: any) => ({
libs: { getComponentSystem: () => ({ registry }) },
});

Comment thread
Exeloo marked this conversation as resolved.
describe("Registry", () => {
describe("entity management", () => {
it("should spawn an entity with id 0", async () => {
Expand Down Expand Up @@ -116,7 +112,7 @@ describe("Registry", () => {

for (let i = 0; i <= 15; i++) {
expect(counter).toBe(i);
r.runSystems(getRunSystemsParams(r));
r.runSystems({});
}
expect(counter).toBe(16);
});
Expand Down Expand Up @@ -148,12 +144,12 @@ describe("Registry", () => {

expect(r.getComponents(Position).size()).toEqual(3);

r.runSystems(getRunSystemsParams(r));
r.runSystems({});
expect(r.getComponents(Position).get(e.getId())).toStrictEqual(new Position(-1, -1));
expect(r.getComponents(Position).get(e2.getId())).toStrictEqual(new Position(1, 1));
expect(r.getComponents(Position).get(e3.getId())).toStrictEqual(new Position(0, 0));

r.runSystems(getRunSystemsParams(r));
r.runSystems({});
expect(r.getComponents(Position).get(e.getId())).toStrictEqual(new Position(0, 0));
expect(r.getComponents(Position).get(e2.getId())).toStrictEqual(new Position(0, 0));
expect(r.getComponents(Position).get(e3.getId())).toStrictEqual(new Position(0, 0));
Expand Down
4 changes: 4 additions & 0 deletions packages/ecs-server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
// @ts-ignore
Comment thread
Tchips46 marked this conversation as resolved.
Outdated
import ECSModule from "../lib/libecs";
// @ts-ignore
import "../lib/libecs.wasm";

export type {
Expand All @@ -12,3 +14,5 @@ export type {
} from "@nanoforge-dev/ecs-lib";

export { ECSServerLibrary } from "./ecs-server-library";

export const Module = ECSModule;
Loading