Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for V2 #137

Closed
wants to merge 10 commits into from
Closed

Add support for V2 #137

wants to merge 10 commits into from

Conversation

nanovna
Copy link

@nanovna nanovna commented Jan 17, 2020

This patch adds support for V2 (S-A-A-2) hardware.

I have only tested this on Linux (debian), consider testing more platforms and more V1 device/firmware variants to make sure it doesn't break anything before merging.

@nanovna nanovna requested a review from mihtjel as a code owner January 17, 2020 03:38
@mihtjel
Copy link
Member

mihtjel commented Jan 27, 2020

Hi,
thanks for these updates. Is there documentation for the protocol used with the "NanoVNA V2"? Is the hardware available yet "in the wild"?

@nanovna
Copy link
Author

nanovna commented Jan 28, 2020

There is a preliminary user guide that has a description of the protocol:
ug1101.pdf
See "Appendix II – USB data interface".

Some users have been sent sample/demo units.
If you would like a sample write to [email protected]

Wide availability of the hardware will begin after Chinese New Year.

@goldstar611
Copy link

Hi @nanovna I have a PR open that may need adjusting if yours is merged first. Could I ask your help testing my PR with the v2 nanoVNA? It basically adds a "pause stimulus" serial command after scan/sweep. You should only need to add a def pauseSweep override in your class.

#173

Let me know if it works on the v2 nanoVNA, thanks!

@nanovna
Copy link
Author

nanovna commented Apr 21, 2020

Hi, I'll be doing a rebase later after your patch is merged, and then I can fix any issues that come up.

@zarath
Copy link
Collaborator

zarath commented Apr 21, 2020

I don't know when Rune gets time for working on NanoVNA-Saver again (and when he get's his V2).
In the mean time I've done some rebasing on nanavna's patch as well as Windows fixes on my fhttps://github.com/zarath/nanovna-saver/tree/feature/nanovna-v2 branch.

And as Rune noted somewhere, he isn't working on master branch, so he likes to get MRs to the Development branch.

Regards
Holger

P.s.: There seems to be some problems with S21 measurement with that patch (mentioned in groups.io mailing list. But I've not got the time to check and conform this issue.

@zarath
Copy link
Collaborator

zarath commented May 16, 2020

I have merged and adjusted the code for the current Development branch and made it available as master in my repository https://github.com/zarath/nanovna-saver.git

But not fixed that mentioned s21 issue

@zarath
Copy link
Collaborator

zarath commented Jun 27, 2020

included in v0.3.0

@zarath zarath closed this Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants