Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I build (for Windows) the version from commit
a04d6d9b3995eabe26a41c9d5abc56678dd8b035
the final executable show the follow error if you try to execute:With this changes on build, the
pyinstaller
find correctly the Qt6 dependency and link on the final executable.Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
pyinstaller
build the executable, but can't correct link the PyQt6.sip dependency.Issue Number: 1
What is the new behavior?
pyinstaller
find PyQt6.sip and Qt6 dependency, correctly.Does this introduce a breaking change?
Other information
This change only affects the Windows compilation, may be useful for Linux and MacOS, when it was in interest to FIX their build.