Pass content-type header to fix filters #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was implementing this library using the a Guzzle7 http client. When trying to do a request to `companies.list` with a filter, the filter did not seem to be applied. By changing my own Guzzle Client to always pass the `Content-Type` header, this was fixed. This shouldn't be necessary to configure on the outside though since the library itself knows that it always sends JSON bodies. Let's thus adapt the API Client itself so that custom http clients don't have to add this header themselves.
mark-gerarts
approved these changes
Dec 14, 2023
|
Any chance of getting this merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was implementing this library using the a Guzzle7 http client. When trying to do a request to
companies.listwith a filter, the filter did not seem to be applied.By changing my own Guzzle Client to always pass the
Content-Typeheader, this was fixed. This shouldn't be necessary to configure on the outside though since the library itself knows that it always sends JSON bodies. Let's thus adapt the API Client itself so that custom http clients don't have to add this header themselves.