Skip to content

Add progress bar unit tests - #335

Merged
ppinchuk merged 9 commits into
mainfrom
pp/pb_tests
Nov 17, 2025
Merged

Add progress bar unit tests#335
ppinchuk merged 9 commits into
mainfrom
pp/pb_tests

Conversation

@ppinchuk

@ppinchuk ppinchuk commented Nov 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Overview

This pull request adds comprehensive unit tests for the compass.pb module, which handles progress bar functionality in the COMPASS CLI.

  • Adds 501 lines of test coverage for progress bar helpers
  • Tests core functionality including main tasks, jurisdiction bars, file downloads, and website crawling progress bars
  • Includes async tests for context managers and proper cleanup verification

@ppinchuk
ppinchuk requested a review from castelao as a code owner November 9, 2025 02:29
Copilot AI review requested due to automatic review settings November 9, 2025 02:29
@ppinchuk ppinchuk self-assigned this Nov 9, 2025
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python labels Nov 9, 2025
@ppinchuk ppinchuk added this to the Finishing touches for OSS milestone Nov 9, 2025
Copilot AI reviewed Nov 9, 2025
View reviewed changes

Copilot AI left a comment •
edited by ppinchuk
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to main description

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

castelao
castelao approved these changes Nov 17, 2025
View reviewed changes

@castelao castelao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still didn't get used to COMPASS' progress bar. It is so cool!

@ppinchuk
ppinchuk merged commit 782ae70 into main Nov 17, 2025
12 checks passed
@ppinchuk
ppinchuk deleted the pp/pb_tests branch November 17, 2025 16:09
rajeee pushed a commit that referenced this pull request May 27, 2026
@ppinchuk
Add progress bar unit tests (#335)
7e8997c 
* initial tests

* Add another test

* Style updates

* Minor formatting

* More formatting

* Formatting

* Rename fixtures

* Update style

* Minor update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@castelao castelao castelao approved these changes

Assignees

@ppinchuk ppinchuk

Labels

enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python

Projects

None yet

Milestone

Finishing touches for OSS

Development

Successfully merging this pull request may close these issues.

3 participants

@ppinchuk @castelao